Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 186023002: DO NOT REVIEW Plumb push messaging registration through to gcm. (Closed)

Created:
6 years, 9 months ago by Michael van Ouwerkerk
Modified:
6 years, 5 months ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix bad upload. #

Patch Set 3 : Rebase. Delete cert enum and param. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+533 lines, -1 line) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 3 chunks +8 lines, -1 line 0 comments Download
A chrome/browser/push_messaging/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/push_messaging/push_messaging_service_impl.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A content/browser/push_messaging_message_filter.h View 1 chunk +53 lines, -0 lines 0 comments Download
A content/browser/push_messaging_message_filter.cc View 1 chunk +89 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/push_messaging_messages.h View 1 chunk +33 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A content/public/browser/push_messaging_service.h View 1 chunk +28 lines, -0 lines 0 comments Download
A content/public/common/push_messaging_status.h View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A content/public/common/push_messaging_status.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A content/renderer/push_messaging_dispatcher.h View 1 chunk +50 lines, -0 lines 0 comments Download
A content/renderer/push_messaging_dispatcher.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael van Ouwerkerk
6 years, 9 months ago (2014-03-03 19:53:03 UTC) #1
Michael van Ouwerkerk
Hi Jochen, this needs to be broken into smaller pieces, and tests. Could you please ...
6 years, 9 months ago (2014-03-10 15:20:30 UTC) #2
jochen (gone - plz use gerrit)
On 2014/03/10 15:20:30, Michael van Ouwerkerk wrote: > Hi Jochen, this needs to be broken ...
6 years, 9 months ago (2014-03-11 14:41:19 UTC) #3
Michael van Ouwerkerk
On 2014/03/11 14:41:19, jochen wrote: > On 2014/03/10 15:20:30, Michael van Ouwerkerk wrote: > > ...
6 years, 9 months ago (2014-03-11 15:38:03 UTC) #4
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-12 13:01:34 UTC) #5
ok, overall the direction looks good

Powered by Google App Engine
This is Rietveld 408576698