tools/CopyTilesRenderer.cpp - Issue 327403002: Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/CopyTilesRenderer.cpp

Issue 327403002: Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/CopyTilesRenderer.cpp

diff --git a/tools/CopyTilesRenderer.cpp b/tools/CopyTilesRenderer.cpp

index 245685568a6e1583f9afb2f6a2ecb619ef371e5f..ebd33d88511b3682330026dba49dac1faa5c8177 100644

--- a/tools/CopyTilesRenderer.cpp

+++ b/tools/CopyTilesRenderer.cpp

@@ -71,8 +71,8 @@ namespace sk_tools {

// a bitmap directly.

// TODO: Share more common code with write() to do this, to properly

// write out the JSON summary, etc.

- SkString pathWithNumber;

- make_filepath(&pathWithNumber, fWritePath, fInputFilename);

+ SkString pathWithNumber = SkOSPath::SkPathJoin(fWritePath.c_str(),

+ fInputFilename.c_str());

pathWithNumber.remove(pathWithNumber.size() - 4, 4);

pathWithNumber.appendf("%i.png", i++);

SkBitmap copy;

« no previous file with comments | « tests/PictureUtilsTest.cpp ('k') | tools/bench_pictures_main.cpp » ('j') | no next file with comments »