Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 327323003: Support [handles] in validation test input format and add handle-related tests. (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Support [handles] in validation test input format and add handle-related tests. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277344

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -49 lines) Patch
M mojo/public/cpp/bindings/tests/validation_test_input_parser.h View 1 2 chunks +11 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_test_input_parser.cc View 1 13 chunks +64 lines, -27 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 12 chunks +33 lines, -20 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_good.data View 1 chunk +35 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_good.expected View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_good_invalid_handle.data View 1 chunk +36 lines, -0 lines 0 comments Download
A + mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_good_invalid_handle.expected View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_handle_out_of_range.data View 1 chunk +15 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_handle_out_of_range.expected View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_multiple_handles_with_same_value_1.data View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_multiple_handles_with_same_value_1.expected View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_multiple_handles_with_same_value_2.data View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_multiple_handles_with_same_value_2.expected View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_wrong_handle_order.data View 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd5_wrong_handle_order.expected View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yzshen1
Hi, Tom. Would you please take a look? Thanks!
6 years, 6 months ago (2014-06-11 23:44:31 UTC) #1
Tom Sepez
LGTM, but can we also get a test where two consumers are aliased to the ...
6 years, 6 months ago (2014-06-12 19:11:39 UTC) #2
yzshen1
On 2014/06/12 19:11:39, Tom Sepez wrote: > LGTM, but can we also get a test ...
6 years, 6 months ago (2014-06-12 19:32:58 UTC) #3
yzshen1
On 2014/06/12 19:11:39, Tom Sepez wrote: > LGTM, but can we also get a test ...
6 years, 6 months ago (2014-06-12 20:09:22 UTC) #4
Tom Sepez
> Ah, I think I got what you mean. > You suggest we add a ...
6 years, 6 months ago (2014-06-12 20:11:06 UTC) #5
yzshen1
On 2014/06/12 20:11:06, Tom Sepez wrote: > > Ah, I think I got what you ...
6 years, 6 months ago (2014-06-12 20:18:35 UTC) #6
Tom Sepez
lgtm
6 years, 6 months ago (2014-06-12 20:20:18 UTC) #7
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-06-15 23:23:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/327323003/40001
6 years, 6 months ago (2014-06-15 23:23:44 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 01:09:11 UTC) #10
Message was sent while issue was closed.
Change committed as 277344

Powered by Google App Engine
This is Rietveld 408576698