Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 327023002: Revert 276039 "Another try at fixing --enable-logging on Windows" (Closed)

Created:
6 years, 6 months ago by ccameron
Modified:
6 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 276039 "Another try at fixing --enable-logging on Windows" Speculative revert for XP failures (based on bug history) http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31536 > Another try at fixing --enable-logging on Windows > > Per details logged on connect bug and crbug, when linked as a Windows > subsystem binary, the _fileno() for stdin/stdout/stderr are incorrectly set > to 0,1,2 rather than all -2 (because there's no console attached). This > was broken between VS2010->VS2012 and is still broken in the latest VS2013 > update. > > So, instead of only checking _fileno, we also check the underlying HANDLE > to confirm that it's valid for that stream before aborting. > > BUG=358267 > BUG=https://connect.microsoft.com/VisualStudio/feedback/details/785119/#tabs > > Review URL: https://codereview.chromium.org/324493003 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M trunk/src/base/process/launch_win.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ccameron
6 years, 6 months ago (2014-06-10 19:43:08 UTC) #1
ccameron
Committed patchset #1 manually as r276123 (tree was closed).
6 years, 6 months ago (2014-06-10 19:43:15 UTC) #2
scottmg
6 years, 6 months ago (2014-06-10 23:01:40 UTC) #3
Message was sent while issue was closed.
Rarrrrrr XP, and no trybot coverage. Thanks for reverting Chris.

Powered by Google App Engine
This is Rietveld 408576698