Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 324493003: Another try at fixing --enable-logging on Windows (Closed)

Created:
6 years, 6 months ago by scottmg
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Another try at fixing --enable-logging on Windows Per details logged on connect bug and crbug, when linked as a Windows subsystem binary, the _fileno() for stdin/stdout/stderr are incorrectly set to 0,1,2 rather than all -2 (because there's no console attached). This was broken between VS2010->VS2012 and is still broken in the latest VS2013 update. So, instead of only checking _fileno, we also check the underlying HANDLE to confirm that it's valid for that stream before aborting. BUG=358267 BUG=https://connect.microsoft.com/VisualStudio/feedback/details/785119/#tabs Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M base/process/launch_win.cc View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
6 years, 6 months ago (2014-06-06 22:20:22 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-09 16:49:58 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 6 months ago (2014-06-09 16:58:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/324493003/1
6 years, 6 months ago (2014-06-09 16:59:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 05:02:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 11:04:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150086)
6 years, 6 months ago (2014-06-10 11:04:17 UTC) #7
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 6 months ago (2014-06-10 14:45:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/324493003/1
6 years, 6 months ago (2014-06-10 14:47:05 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 15:47:09 UTC) #10
Message was sent while issue was closed.
Change committed as 276039

Powered by Google App Engine
This is Rietveld 408576698