chrome/browser/metrics/omnibox_metrics_provider.cc - Issue 327003003: [AiS] Add a new AutocompleteMatchType for Answers in Suggest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/omnibox_metrics_provider.cc

Issue 327003003: [AiS] Add a new AutocompleteMatchType for Answers in Suggest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/base_search_provider.cc ('K') | « chrome/browser/autocomplete/shortcuts_backend_unittest.cc ('k') | chrome/common/autocomplete_match_type.h » ('j') | components/metrics/proto/omnibox_event.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/omnibox_metrics_provider.cc

diff --git a/chrome/browser/metrics/omnibox_metrics_provider.cc b/chrome/browser/metrics/omnibox_metrics_provider.cc

index 94847f91d7f956d459ade096b449ad1e85b078bf..2b9921744ef830306afcff0c55638862cd20ffb0 100644

--- a/chrome/browser/metrics/omnibox_metrics_provider.cc

+++ b/chrome/browser/metrics/omnibox_metrics_provider.cc

@@ -54,6 +54,8 @@ OmniboxEventProto::Suggestion::ResultType AsOmniboxEventResultType(

return OmniboxEventProto::Suggestion::SEARCH_SUGGEST_PERSONALIZED;

case AutocompleteMatchType::SEARCH_SUGGEST_PROFILE:

return OmniboxEventProto::Suggestion::SEARCH_SUGGEST_PROFILE;

+ case AutocompleteMatchType::SEARCH_SUGGEST_ANSWER:

+ return OmniboxEventProto::Suggestion::SEARCH_SUGGEST_ANSWER;

case AutocompleteMatchType::SEARCH_OTHER_ENGINE:

return OmniboxEventProto::Suggestion::SEARCH_OTHER_ENGINE;

case AutocompleteMatchType::EXTENSION_APP: