Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4418)

Unified Diff: chrome/browser/autocomplete/base_search_provider.cc

Issue 327003003: [AiS] Add a new AutocompleteMatchType for Answers in Suggest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/base_search_provider.cc
diff --git a/chrome/browser/autocomplete/base_search_provider.cc b/chrome/browser/autocomplete/base_search_provider.cc
index 3de7d4126c3641dfdc2d2311144f8c5b075dbc26..cf0ca1d9213ad0eb42165ba2c263b63988f8360b 100644
--- a/chrome/browser/autocomplete/base_search_provider.cc
+++ b/chrome/browser/autocomplete/base_search_provider.cc
@@ -915,6 +915,7 @@ bool BaseSearchProvider::ParseSuggestResults(const base::Value& root_val,
// Extract Answers, if provided.
const base::DictionaryValue* answer_json = NULL;
if (suggestion_detail->GetDictionary("ansa", &answer_json)) {
+ match_type = AutocompleteMatchType::SEARCH_SUGGEST_ANSWER;
Peter Kasting 2014/06/10 21:49:46 My only concern here would be if there's a validat
Justin Donnelly 2014/06/11 15:51:53 Good question, but no we don't plan to downgrade a
std::string contents;
base::JSONWriter::Write(answer_json, &contents);
answer_contents = base::UTF8ToUTF16(contents);

Powered by Google App Engine
This is Rietveld 408576698