Issue 3270004: Re-enable SerializeHTMLDOMWithEntitiesInAttributeValue and SerializeHTMLDOMWi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3270004: Re-enable SerializeHTMLDOMWithEntitiesInAttributeValue and SerializeHTMLDOMWi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by rniwa-cr

Modified:
3 years, 11 months ago

Reviewers:
jamesr, eseidel

CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Re-enable SerializeHTMLDOMWithEntitiesInAttributeValue and SerializeHTMLDOMWithNonStandardEntities since they are fixed by merging WebKit r66131 in http://src.chromium.org/viewvc/chrome?view=rev&revision=57724. No new tests are added since this is a test fix. BUG=53148 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57768

Patch Set 1 #

Patch Set 2 : '' #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webkit/glue/dom_serializer_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamesr

LGTM, but do not check this in until you have green trybot runs.

4 years, 9 months ago (2010-08-27 22:46:10 UTC) #1

rniwa-cr

4 years, 9 months ago (2010-08-28 01:40:20 UTC) #2

Results are:
http://build.chromium.org/buildbot/try-server/builders/linux/builds/44481
http://build.chromium.org/buildbot/try-server/builders/mac/builds/44361
http://build.chromium.org/buildbot/try-server/builders/win/builds/47169

Expand Messages | Collapse Messages