Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 326913007: Clean up SkScaledImageCache at exit only in SK_DEVELOPER mode. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Clean up SkScaledImageCache at exit only in SK_DEVELOPER mode. This is triggering ASAN failures in Chrome unit tests. c.f. https://codereview.chromium.org/308003014 BUG=skia: Committed: https://skia.googlesource.com/skia/+/77ec7a6f44ccfdacc9c3422516f09720ca17f9e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/core/SkScaledImageCache.cpp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 6 months ago (2014-06-10 17:26:13 UTC) #1
reed1
lgtm
6 years, 6 months ago (2014-06-10 17:28:46 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-10 17:29:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/326913007/1
6 years, 6 months ago (2014-06-10 17:29:52 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 18:13:52 UTC) #5
Message was sent while issue was closed.
Change committed as 77ec7a6f44ccfdacc9c3422516f09720ca17f9e2

Powered by Google App Engine
This is Rietveld 408576698