Issue 308003014: Clean up SkLazyPtrs only in SK_DEVELOPER mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308003014: Clean up SkLazyPtrs only in SK_DEVELOPER mode. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
bungeman-skia, mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Clean up SkLazyPtrs only in SK_DEVELOPER mode. Checking only SK_DEBUG may make SkLazyPtr too anal about leaks for clients. Still working through strange leak problems inside Skia tests, so it's probably premature to turn it on in Chrome tests. BUG=379570 Committed: https://skia.googlesource.com/skia/+/0d03db7446126be6ccce744be9b37ef475142e16

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/core/SkLazyPtr.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mtklein

+Ben Silly me, I started with a missing Mike to review this.

6 years, 6 months ago (2014-06-02 14:12:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/308003014/1

6 years, 6 months ago (2014-06-02 14:47:49 UTC) #5

commit-bot: I haz the power

6 years, 6 months ago (2014-06-02 14:53:05 UTC) #6

Message was sent while issue was closed.

Change committed as 0d03db7446126be6ccce744be9b37ef475142e16

Expand Messages | Collapse Messages