Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 326853002: Revert of Add an ASSERT about cross-world wrapper leakage into ScriptValue (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Visibility:
Public.

Description

Revert of Add an ASSERT about cross-world wrapper leakage into ScriptValue (https://codereview.chromium.org/314953005/) Reason for revert: Causes many browser_tests to fail: ActiveScriptControllerBrowserTest.* ExtensionApiTest.ContentScript* etc Original issue's description: > Add an ASSERT about cross-world wrapper leakage into ScriptValue > > - This CL adds an ASSERT to ScriptValue to verify that ScriptValue::v8Value() is used in the same world that created the ScriptValue. > > - To insert the check, we need to get a current world in ScriptValue::v8Value(). For that goal, this CL makes sure that we're in some context when calling ScriptValue::v8Value(). > > BUG=341032 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175837 TBR=dcarney@chromium.org,adamk@chromium.org,jochen@chromium.org,tasak@google.com,abarth@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=341032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -102 lines) Patch
M Source/bindings/v8/ScriptController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 6 chunks +16 lines, -20 lines 0 comments Download
M Source/bindings/v8/ScriptPreprocessor.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptPromise.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptPromise.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptValue.h View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptValue.cpp View 1 chunk +1 line, -18 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptBase.h View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/inspector/InjectedScriptBase.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/InstallPhaseEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/InstallPhaseEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/InstallPhaseEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Add an ASSERT about cross-world wrapper leakage into ScriptValue
6 years, 6 months ago (2014-06-10 06:08:30 UTC) #1
haraken
LGTM, thanks for the revert!
6 years, 6 months ago (2014-06-10 06:09:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/326853002/1
6 years, 6 months ago (2014-06-10 06:09:44 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 06:10:21 UTC) #4
Message was sent while issue was closed.
Change committed as 175862

Powered by Google App Engine
This is Rietveld 408576698