Source/core/inspector/JavaScriptCallFrame.cpp - Issue 326853002: Revert of Add an ASSERT about cross-world wrapper leakage into ScriptValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/JavaScriptCallFrame.cpp

Issue 326853002: Revert of Add an ASSERT about cross-world wrapper leakage into ScriptValue (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/JavaScriptCallFrame.cpp

diff --git a/Source/core/inspector/JavaScriptCallFrame.cpp b/Source/core/inspector/JavaScriptCallFrame.cpp

index 4add3bcbb8a8f32485103b99bb679c47f8e6b13f..c52ebe7757712c7bbf4550ae10425d1d1df64a5d 100644

--- a/Source/core/inspector/JavaScriptCallFrame.cpp

+++ b/Source/core/inspector/JavaScriptCallFrame.cpp

@@ -170,7 +170,6 @@

ScriptValue JavaScriptCallFrame::setVariableValue(ScriptState* scriptState, int scopeNumber, const String& variableName, const ScriptValue& newValue)

{

- ScriptState::Scope scriptScope(scriptState);

v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);

v8::Handle<v8::Function> setVariableValueFunction = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "setVariableValue")));

v8::Handle<v8::Value> argv[] = {

« no previous file with comments | « Source/core/inspector/InjectedScriptHost.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »