Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 326763002: Adding WebFallbackFont and renaming SimpleFontFamily (Closed)

Created:
6 years, 6 months ago by Dominik Röttsches
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, Rik, danakj, dglazkov+blink, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Adding WebFallbackFont and renaming SimpleFontFamily Step 1 of renames preceding the fix for family based fallback font selection. BUG=382411 R=eae,behdad Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175858

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -33 lines) Patch
M Source/platform/exported/linux/WebFontInfo.cpp View 3 chunks +87 lines, -0 lines 0 comments Download
M Source/platform/fonts/Font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/platform/fonts/android/FontCacheAndroid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/android/FontCacheAndroidTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/linux/FontCacheLinux.cpp View 1 chunk +18 lines, -8 lines 0 comments Download
M Source/platform/fonts/mac/FontCacheMac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/linux/WebFallbackFont.h View 1 chunk +6 lines, -4 lines 0 comments Download
M public/platform/linux/WebFontInfo.h View 2 chunks +4 lines, -0 lines 0 comments Download
M public/platform/linux/WebSandboxSupport.h View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Dominik Röttsches
PTAL
6 years, 6 months ago (2014-06-09 21:50:56 UTC) #1
eae
LGTM
6 years, 6 months ago (2014-06-09 21:56:39 UTC) #2
Dominik Röttsches
On 2014/06/09 21:56:39, eae wrote: > LGTM Thanks for the quick review. I'll fix the ...
6 years, 6 months ago (2014-06-09 22:07:27 UTC) #3
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 6 months ago (2014-06-09 22:12:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/326763002/20001
6 years, 6 months ago (2014-06-09 22:14:34 UTC) #5
Dominik Röttsches
Adam, could you approve the public/platform/linux/ changes?
6 years, 6 months ago (2014-06-09 22:24:16 UTC) #6
behdad_google
https://codereview.chromium.org/326763002/diff/1/Source/platform/exported/linux/WebFontInfo.cpp File Source/platform/exported/linux/WebFontInfo.cpp (right): https://codereview.chromium.org/326763002/diff/1/Source/platform/exported/linux/WebFontInfo.cpp#newcode136 Source/platform/exported/linux/WebFontInfo.cpp:136: FcPatternAdd(pattern, FC_CHARSET, fcvalue, FcFalse); See "man FcPatternAdd-Type". Use FcPatternAddCharSet, ...
6 years, 6 months ago (2014-06-09 22:27:58 UTC) #7
behdad_google
lgtm
6 years, 6 months ago (2014-06-09 22:28:08 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-09 23:21:51 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 23:24:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7333)
6 years, 6 months ago (2014-06-09 23:24:34 UTC) #11
abarth-chromium
public/ LGTM
6 years, 6 months ago (2014-06-10 00:03:59 UTC) #12
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 6 months ago (2014-06-10 05:15:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/326763002/20001
6 years, 6 months ago (2014-06-10 05:16:59 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 05:20:14 UTC) #15
Message was sent while issue was closed. 
Change committed as 175858

Powered by Google App Engine
This is Rietveld 408576698