Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: public/platform/linux/WebSandboxSupport.h

Issue 326763002: Adding WebFallbackFont and renaming SimpleFontFamily (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing mac build Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/linux/WebFontInfo.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/linux/WebSandboxSupport.h
diff --git a/public/platform/linux/WebSandboxSupport.h b/public/platform/linux/WebSandboxSupport.h
index d0ae30c21ddcafd4e2cb1a0362a61d74fda0d7f2..5da799139f89a4151e11e68a841c477fb09ea6a0 100644
--- a/public/platform/linux/WebSandboxSupport.h
+++ b/public/platform/linux/WebSandboxSupport.h
@@ -33,6 +33,7 @@
#include "../WebCommon.h"
#include "../WebString.h"
+#include "WebFallbackFont.h"
#include "WebFontFamily.h"
namespace blink {
@@ -44,16 +45,19 @@ struct WebFontRenderStyle;
// https://code.google.com/p/chromium/wiki/LinuxSandboxIPC
class WebSandboxSupport {
public:
- // Get a font family which contains glyphs for the given Unicode code-point.
+ // Get information to instantiate a font which contains glyphs for the given Unicode code-point.
// character: a UTF-32 codepoint
// preferredLocale: preferred locale identifier for the |characters|
// (e.g. "en", "ja", "zh-CN")
//
- // Returns a string with the font family on an empty string if the
- // request cannot be satisfied.
// Returns a WebFontFamily instance with the font name. The instance has empty font name if the request cannot be satisfied.
virtual void getFontFamilyForCharacter(WebUChar32, const char* preferredLocale, WebFontFamily*) = 0;
+ // TODO(dro): crbug.com/382411 Add a new version on the Chromium side to complete
+ // the WebFontFamily->WebFallbackFont rename, like
+ // virtual void getFallbackFontForCharacter(WebUChar32, const char* preferredLocale, WebFallbackFont*) = 0;
+ // then add it here.
+
virtual void getRenderStyleForStrike(const char* family, int sizeAndStyle, WebFontRenderStyle*) = 0;
};
« no previous file with comments | « public/platform/linux/WebFontInfo.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698