Issue 326483002: Make update-flaky-tests work for debug builders as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 326483002: Make update-flaky-tests work for debug builders as well. (Closed)

Created:
6 years, 6 months ago by ojan

Modified:
6 years, 6 months ago

Reviewers:
Dirk Pranke, eseidel

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make update-flaky-tests work for debug builders as well. We were just looping over port names before, which will default us to only use release builds. Also, that's wrong anyways because there's no guarantee that a port actually runs on a builder yet. Instead, loop over the builders. We assume throughout the codebase that these builders upload results to the flakiness dashboard, so it's correct to use the builders list here. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175811

Patch Set 1 #

Patch Set 2 : add tests #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -12 lines)			Patch
M	Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py	View		1 chunk	+18 lines, -5 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Tools/Scripts/webkitpy/tool/commands/flakytests.py	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/326483002/20001

6 years, 6 months ago (2014-06-09 17:14:15 UTC) #4

Message was sent while issue was closed.

Change committed as 175811

Expand Messages | Collapse Messages