Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 326483002: Make update-flaky-tests work for debug builders as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 326483002: Make update-flaky-tests work for debug builders as well. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/base.py b/Tools/Scripts/webkitpy/layout_tests/port/base.py

index 6edb5685c158448eae388f22139cb343f2cd10f8..4078bdc9bcf42cd9d7c948c2e1e7079019b9cd05 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -1262,6 +1262,8 @@ class Port(object):

full_port_name = self.determine_full_port_name(self.host, self._options, self.port_name)

builder_category = self.get_option('ignore_builder_category', 'layout')

factory = BotTestExpectationsFactory()

+ # FIXME: This only grabs release builder's flakiness data. If we're running debug,

+ # when we should grab the debug builder's data.

expectations = factory.expectations_for_port(full_port_name, builder_category)

if not expectations: