Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 326453002: Use UTS46 API to convert IDN in Unicode to punycode (Closed)

Created:
6 years, 6 months ago by jungshik at Google
Modified:
6 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Visibility:
Public.

Description

Use UTS46 API to convert IDN in Unicode to punycode When upgrading ICU to 52, I removed the stringprep data for IDNA 2003 because Chrome/Blink switched to UTS46/IDNA 2008. I overlooked that Blink email form handling still uses IDNA 2003 API that fails without stringprep data for IDNA 2003. This CL changes Blink to use UTS46 API. BUG=132145, 376587 TEST=LayoutTest: fast/forms/email-idn-conversion.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175869

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : directly call createUTS46 without a wrapper #

Patch Set 4 : remove an unused IDNAWrapper #

Patch Set 5 : use ASSERT and add comment #

Patch Set 6 : use buffer-copy ctor for UnicodeString instead of copy-on-write (debug build failure) #

Patch Set 7 : comment only change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M Source/core/html/forms/EmailInputType.cpp View 1 2 3 4 5 6 3 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
jungshik at Google
Can you take a look? Thanks
6 years, 6 months ago (2014-06-07 07:55:03 UTC) #1
Kunihiko Sakamoto
lgtm Thanks for doing this.
6 years, 6 months ago (2014-06-09 02:12:29 UTC) #2
jungshik at Google
Thanks for a quick review. Adding to CQ
6 years, 6 months ago (2014-06-09 05:17:50 UTC) #3
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 6 months ago (2014-06-09 05:17:54 UTC) #4
jungshik at Google
The CQ bit was unchecked by jshin@chromium.org
6 years, 6 months ago (2014-06-09 05:17:57 UTC) #5
jungshik at Google
@abarth, can you approve the CL?
6 years, 6 months ago (2014-06-09 05:18:38 UTC) #6
jungshik at Google
Ooops. forgot to add abarth to Reviewers list. @abarth, can you approve the CL? Thanks
6 years, 6 months ago (2014-06-09 05:19:39 UTC) #7
abarth-chromium
Test? rslgtm
6 years, 6 months ago (2014-06-09 17:27:47 UTC) #8
jungshik at Google
On 2014/06/09 17:27:47, abarth wrote: > Test? fast/forms/email-idn-conversion.html covers that, but perhaps a unittest would ...
6 years, 6 months ago (2014-06-09 19:27:22 UTC) #9
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 6 months ago (2014-06-09 19:27:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/326453002/80001
6 years, 6 months ago (2014-06-09 19:28:11 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-09 20:34:20 UTC) #12
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 6 months ago (2014-06-10 05:57:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/326453002/120001
6 years, 6 months ago (2014-06-10 05:57:38 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-10 06:51:12 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 07:30:13 UTC) #16
Message was sent while issue was closed.
Change committed as 175869

Powered by Google App Engine
This is Rietveld 408576698