Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 326443002: Remove CompositingUpdateOnScroll (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
esprehn, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, Ian Vollick, zoltan1
Visibility:
Public.

Description

Remove CompositingUpdateOnScroll This CL teaches the callers of CompositingUpdateOnScroll how to do partial compositing updates. Now that they're smarter, we can use CompositingUpdateAfterCompositingInputChange and we don't need CompositingUpdateOnScroll anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-06 21:54:34 UTC) #1
esprehn
lgtm, but can we not make setNeedsToUpdateAncestorDependentProperties() call setNeedsCompositingUpdate(CompositingUpdateAfterCompositingInputChange) ? It's really weird that it ...
6 years, 6 months ago (2014-06-06 22:15:26 UTC) #2
abarth-chromium
On 2014/06/06 22:15:26, esprehn wrote: > lgtm, but can we not make setNeedsToUpdateAncestorDependentProperties() call > ...
6 years, 6 months ago (2014-06-06 22:37:31 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-06 22:38:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/326443002/1
6 years, 6 months ago (2014-06-06 22:39:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 23:06:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 23:16:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10694)
6 years, 6 months ago (2014-06-06 23:16:18 UTC) #8
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-07 01:20:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/326443002/1
6 years, 6 months ago (2014-06-07 01:21:59 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:46:39 UTC) #11
Message was sent while issue was closed.
Change committed as 175729

Powered by Google App Engine
This is Rietveld 408576698