Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 326443002: Remove CompositingUpdateOnScroll (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1663 matching lines...) Expand 10 before | Expand all | Expand 10 after
1674 if (!hasViewportConstrainedObjects()) 1674 if (!hasViewportConstrainedObjects())
1675 return; 1675 return;
1676 1676
1677 RefPtr<FrameView> protect(this); 1677 RefPtr<FrameView> protect(this);
1678 1678
1679 // If there fixed position elements, scrolling may cause compositing layers to change. 1679 // If there fixed position elements, scrolling may cause compositing layers to change.
1680 // Update widget and layer positions after scrolling, but only if we're not inside of 1680 // Update widget and layer positions after scrolling, but only if we're not inside of
1681 // layout. 1681 // layout.
1682 if (!m_nestedLayoutCount) { 1682 if (!m_nestedLayoutCount) {
1683 updateWidgetPositions(); 1683 updateWidgetPositions();
1684 if (RenderView* renderView = this->renderView()) 1684 if (RenderView* renderView = this->renderView()) {
1685 renderView->layer()->updateLayerPositionsAfterDocumentScroll(); 1685 renderView->layer()->updateLayerPositionsAfterDocumentScroll();
1686 renderView->layer()->setNeedsToUpdateAncestorDependentProperties();
1687 renderView->compositor()->setNeedsCompositingUpdate(CompositingUpdat eAfterCompositingInputChange);
1688 }
1686 } 1689 }
1687
1688 // Compositing layers may change after scrolling.
1689 // FIXME: Maybe no longer needed after we land squashing and kill overlap te sting?
1690 if (RenderView* renderView = this->renderView())
1691 renderView->compositor()->setNeedsCompositingUpdate(CompositingUpdateOnS croll);
1692 } 1690 }
1693 1691
1694 void FrameView::updateFixedElementPaintInvalidationRectsAfterScroll() 1692 void FrameView::updateFixedElementPaintInvalidationRectsAfterScroll()
1695 { 1693 {
1696 if (!hasViewportConstrainedObjects()) 1694 if (!hasViewportConstrainedObjects())
1697 return; 1695 return;
1698 1696
1699 // Update the paint invalidation rects for fixed elements after scrolling an d invalidation to reflect 1697 // Update the paint invalidation rects for fixed elements after scrolling an d invalidation to reflect
1700 // the new scroll position. 1698 // the new scroll position.
1701 ViewportConstrainedObjectSet::const_iterator end = m_viewportConstrainedObje cts->end(); 1699 ViewportConstrainedObjectSet::const_iterator end = m_viewportConstrainedObje cts->end();
(...skipping 1563 matching lines...) Expand 10 before | Expand all | Expand 10 after
3265 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3263 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3266 { 3264 {
3267 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3265 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3268 if (AXObjectCache* cache = axObjectCache()) { 3266 if (AXObjectCache* cache = axObjectCache()) {
3269 cache->remove(scrollbar); 3267 cache->remove(scrollbar);
3270 cache->handleScrollbarUpdate(this); 3268 cache->handleScrollbarUpdate(this);
3271 } 3269 }
3272 } 3270 }
3273 3271
3274 } // namespace WebCore 3272 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698