Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 326403011: Move PAC DHCP Windows log message back to VLOG() (Closed)

Created:
6 years, 6 months ago by cbentzel
Modified:
6 years, 6 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move PAC DHCP Windows log message back to VLOG() This generates console spam if you are on a network that does not do WPAD-over-DHCP. It looks like this was unintentionally upgraded to a LOG(WARNING) in https://codereview.chromium.org/169193002 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
cbentzel
6 years, 6 months ago (2014-06-12 14:25:35 UTC) #1
viettrungluu
lgtm
6 years, 6 months ago (2014-06-12 15:12:42 UTC) #2
cbentzel
The CQ bit was checked by cbentzel@chromium.org
6 years, 6 months ago (2014-06-12 20:46:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/326403011/1
6 years, 6 months ago (2014-06-12 20:48:02 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 04:06:20 UTC) #5
Message was sent while issue was closed.
Change committed as 276917

Powered by Google App Engine
This is Rietveld 408576698