Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169193002: Convert scoped_ptr_malloc -> scoped_ptr, part 2. (Closed)

Created:
6 years, 10 months ago by viettrungluu
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, mmenke, Ryan Sleevi
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : foo #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -105 lines) Patch
M base/debug/stack_trace_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/net/x509_certificate_model_nss.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/pepper/host_var_tracker_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M crypto/scoped_capi_types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M crypto/scoped_nss_types.h View 1 chunk +22 lines, -27 lines 0 comments Download
M device/hid/hid_connection_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/cup/client_update_protocol_nss.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M media/audio/alsa/alsa_output.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/alsa/audio_manager_alsa.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/io_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_win.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/cert/jwk_serializer_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/scoped_nss_types.h View 2 chunks +4 lines, -6 lines 0 comments Download
M net/cert/x509_cert_types_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/cert/x509_util_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/address_sorter_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/dns/dns_config_service_win.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_config_service_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/dns/dns_config_service_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/socket_stream/socket_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/Wow64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/win/src/acl.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M sandbox/win/src/acl.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M sandbox/win/src/process_thread_policy.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/win/src/target_process.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/target_process.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
viettrungluu
6 years, 10 months ago (2014-02-18 06:58:06 UTC) #1
Ryan Sleevi
Adding willchan, I won't have a chance to review this CL this week.
6 years, 10 months ago (2014-02-18 17:13:40 UTC) #2
willchan no longer on Chromium
net and base lgtm
6 years, 10 months ago (2014-02-18 17:41:16 UTC) #3
DaleCurtis
media/ lgtm
6 years, 10 months ago (2014-02-18 19:15:59 UTC) #4
Ryan Myers (chromium)
google_apis/cup/ lgtm
6 years, 10 months ago (2014-02-18 19:39:55 UTC) #5
miket_OOO
LGTM and thanks!
6 years, 10 months ago (2014-02-18 20:26:07 UTC) #6
cpu_(ooo_6.6-7.5)
rubberstamp lgtm
6 years, 10 months ago (2014-02-19 03:06:53 UTC) #7
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 10 months ago (2014-02-19 06:51:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/169193002/190001
6 years, 10 months ago (2014-02-19 06:51:50 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 08:06:48 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=203358
6 years, 10 months ago (2014-02-19 08:06:49 UTC) #11
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 10 months ago (2014-02-19 17:25:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/169193002/190001
6 years, 10 months ago (2014-02-19 17:30:13 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 19:41:12 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=203497
6 years, 10 months ago (2014-02-19 19:41:13 UTC) #15
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 10 months ago (2014-02-26 16:32:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/169193002/930001
6 years, 10 months ago (2014-02-26 16:35:44 UTC) #17
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 20:30:07 UTC) #18
Message was sent while issue was closed. 
Change committed as 253582

Powered by Google App Engine
This is Rietveld 408576698