Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 326383005: Remove base/platform_file.* (Closed)

Created:
6 years, 6 months ago by rvargas (doing something else)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, nhiroki, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), erikwright+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, qsr+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1408 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M base/base.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 2 chunks +0 lines, -6 lines 0 comments Download
M base/files/file.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M base/files/file_posix.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D base/files/scoped_platform_file_closer.h View 1 chunk +0 lines, -26 lines 0 comments Download
D base/files/scoped_platform_file_closer.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D base/platform_file.h View 1 chunk +0 lines, -268 lines 0 comments Download
D base/platform_file.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D base/platform_file_posix.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D base/platform_file_unittest.cc View 1 chunk +0 lines, -454 lines 0 comments Download
D base/platform_file_win.cc View 1 chunk +0 lines, -226 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/cld_component_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/serial/serial_io_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_browser_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/lorgnette_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/lorgnette_manager_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/breakpad/app/breakpad_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_io_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/renderer_ppapi_host.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_linux.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/embedder/channel_init.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
rvargas (doing something else)
Brett, PTAL TBR owners outside of base.
6 years, 6 months ago (2014-06-23 18:19:58 UTC) #1
Lei Zhang
chrome/ lgtm
6 years, 6 months ago (2014-06-23 18:58:17 UTC) #2
viettrungluu
lgtm mojo lgtm
6 years, 6 months ago (2014-06-23 18:59:31 UTC) #3
brettw
woot LGTM
6 years, 6 months ago (2014-06-23 19:45:04 UTC) #4
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 6 months ago (2014-06-23 19:49:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/326383005/80001
6 years, 6 months ago (2014-06-23 19:50:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-23 20:10:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 20:12:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/24406) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/20476)
6 years, 6 months ago (2014-06-23 20:12:32 UTC) #9
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 6 months ago (2014-06-23 23:32:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/326383005/100001
6 years, 6 months ago (2014-06-23 23:37:16 UTC) #11
rvargas (doing something else)
The CQ bit was unchecked by rvargas@chromium.org
6 years, 6 months ago (2014-06-24 00:09:01 UTC) #12
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 6 months ago (2014-06-24 01:10:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/326383005/120001
6 years, 6 months ago (2014-06-24 01:10:58 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 05:40:18 UTC) #15
Message was sent while issue was closed.
Change committed as 279330

Powered by Google App Engine
This is Rietveld 408576698