Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3993)

Unified Diff: base/files/file.cc

Issue 326383005: Remove base/platform_file.* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gypi ('k') | base/files/file_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file.cc
diff --git a/base/files/file.cc b/base/files/file.cc
index bfe87bdcc4dc9d20653130006d7065afac536c8f..ea8dbf27ac1770d88fc6ce933a4bdd331820d2d9 100644
--- a/base/files/file.cc
+++ b/base/files/file.cc
@@ -3,9 +3,7 @@
// found in the LICENSE file.
#include "base/files/file.h"
-
-// TODO(rvargas): remove this (needed for kInvalidPlatformFileValue).
-#include "base/platform_file.h"
+#include "base/files/file_path.h"
namespace base {
@@ -19,16 +17,14 @@ File::Info::~Info() {
}
File::File()
- : file_(kInvalidPlatformFileValue),
- error_details_(FILE_ERROR_FAILED),
+ : error_details_(FILE_ERROR_FAILED),
created_(false),
async_(false) {
}
#if !defined(OS_NACL)
File::File(const FilePath& name, uint32 flags)
- : file_(kInvalidPlatformFileValue),
- error_details_(FILE_OK),
+ : error_details_(FILE_OK),
created_(false),
async_(false) {
Initialize(name, flags);
@@ -46,8 +42,7 @@ File::File(PlatformFile platform_file)
}
File::File(Error error_details)
- : file_(kInvalidPlatformFileValue),
- error_details_(error_details),
+ : error_details_(error_details),
created_(false),
async_(false) {
}
« no previous file with comments | « base/base.gypi ('k') | base/files/file_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698