Allow compressed texture data to be updated.

Allow compressed texture data to be updated.

Committed: https://skia.googlesource.com/skia/+/145d48c4ccf1024ce0878e5110c0be7d414b7dde

[robertphillips, 2014-06-11 18:20:57]

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.cpp#newco...
src/gpu/gl/GrGpuGL.cpp:489: 
if (success) {
  texture->impl()->dirtyMipMaps(true);
  return true;
}

return false;

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.h#newcode278
src/gpu/gl/GrGpuGL.h:278: // set to -1, then this function will use desc.fWidth
and desc.fHeight
align comment ?

[krajcevski, 2014-06-11 18:58:41]

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.cpp#newco...
src/gpu/gl/GrGpuGL.cpp:489: 
On 2014/06/11 18:20:57, robertphillips wrote:
> if (success) {
>   texture->impl()->dirtyMipMaps(true);
>   return true;
> }
> 
> return false;

Done.

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.chromium.org/326383003/diff/1/src/gpu/gl/GrGpuGL.h#newcode278
src/gpu/gl/GrGpuGL.h:278: // set to -1, then this function will use desc.fWidth
and desc.fHeight
On 2014/06/11 18:20:57, robertphillips wrote:
> align comment ?

Err.. I'm not sure why this is showing up like this in the code review... The
comment is aligned in my code.

[robertphillips, 2014-06-11 19:11:12]

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.cpp#n...
src/gpu/gl/GrGpuGL.cpp:481: if (GrPixelConfigIsCompressed(desc.fConfig)) {
Doesn't there need to be a check somewhere regarding 'config'?

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.h#new...
src/gpu/gl/GrGpuGL.h:279: // for the size of the data.
Dox for what 'isNewTexture' means?

[krajcevski, 2014-06-11 19:20:47]

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.cpp#n...
src/gpu/gl/GrGpuGL.cpp:481: if (GrPixelConfigIsCompressed(desc.fConfig)) {
On 2014/06/11 19:11:12, robertphillips wrote:
> Doesn't there need to be a check somewhere regarding 'config'?

Done.

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.chromium.org/326383003/diff/40001/src/gpu/gl/GrGpuGL.h#new...
src/gpu/gl/GrGpuGL.h:279: // for the size of the data.
On 2014/06/11 19:11:12, robertphillips wrote:
> Dox for what 'isNewTexture' means?

Done.

[robertphillips, 2014-06-11 19:24:46]

https://codereview.chromium.org/326383003/diff/60001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/326383003/diff/60001/src/gpu/gl/GrGpuGL.cpp#n...
src/gpu/gl/GrGpuGL.cpp:749: internalFormat,
Is this path okay if width != desc.fWidth || height != desc.fHeight ?

[robertphillips, 2014-06-11 21:08:46]

lgtm w/ discussed modifications

[krajcevski, 2014-06-11 21:21:44]

https://codereview.chromium.org/326383003/diff/60001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/326383003/diff/60001/src/gpu/gl/GrGpuGL.cpp#n...
src/gpu/gl/GrGpuGL.cpp:749: internalFormat,
On 2014/06/11 19:24:46, robertphillips wrote:
> Is this path okay if width != desc.fWidth || height != desc.fHeight ?

OK, I've added asserts up above.

[krajcevski, 2014-06-11 21:21:47]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-06-11 21:22:04]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/326383003/80001

[krajcevski, 2014-06-11 22:24:35]

The CQ bit was unchecked by krajcevski@google.com

[krajcevski, 2014-06-11 22:24:38]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-06-11 22:24:48]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/326383003/80001

[commit-bot: I haz the power, 2014-06-11 23:07:56]

Change committed as 145d48c4ccf1024ce0878e5110c0be7d414b7dde