Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
326283002:
Accelerate small canvases if Ganesh is on. (Closed)
|
Created:
6 years, 6 months ago by chrishtr Modified:
6 years, 6 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, telemetry+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAccelerate small canvases if Ganesh is on.
cc side of change.
TBR=phajdan.jr@chromium.org
BUG=382738
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276753
Patch Set 1 #Patch Set 2 : Fix. #Patch Set 3 : Fix. #
Messages
Total messages: 21 (0 generated)
Goes with crrev.com/328883002. On Tue, Jun 10, 2014 at 6:06 PM, <chrishtr@chromium.org> wrote: > Reviewers: Ian Vollick, ajuma, > > Description: > Accelerate small canvases if Ganesh is on. > > cc side of change. > > BUG=382738 > > Please review this at https://codereview.chromium.org/326283002/ > > SVN Base: svn://svn.chromium.org/chrome/trunk/src > > Affected files (+10, -0 lines): > M content/renderer/gpu/render_widget_compositor.h > M content/renderer/gpu/render_widget_compositor.cc > M content/test/web_layer_tree_view_impl_for_testing.h > M content/test/web_layer_tree_view_impl_for_testing.cc > > > Index: content/renderer/gpu/render_widget_compositor.cc > diff --git a/content/renderer/gpu/render_widget_compositor.cc > b/content/renderer/gpu/render_widget_compositor.cc > index f1f6101c2d1422c07ff1b10c9d6f021ef7a8c7f0.. > f974828d94a1916a305bc8849e147573a6c1fd56 100644 > --- a/content/renderer/gpu/render_widget_compositor.cc > +++ b/content/renderer/gpu/render_widget_compositor.cc > @@ -710,4 +710,8 @@ void RenderWidgetCompositor:: > RateLimitSharedMainThreadContext() { > provider->ContextGL()->RateLimitOffscreenContextCHROMIUM(); > } > > +bool RenderWidgetCompositor::usesGpuRasterization() { > + return layer_tree_host_->UseGpuRasterization(); > +} > + > } // namespace content > Index: content/renderer/gpu/render_widget_compositor.h > diff --git a/content/renderer/gpu/render_widget_compositor.h > b/content/renderer/gpu/render_widget_compositor.h > index 4160df2de20f5c820d488c05a8106cb794190cc9.. > d973c202de8559a83bedb2c71676e4bfaddb544c 100644 > --- a/content/renderer/gpu/render_widget_compositor.h > +++ b/content/renderer/gpu/render_widget_compositor.h > @@ -120,6 +120,7 @@ class RenderWidgetCompositor : public > blink::WebLayerTreeView, > virtual void setShowDebugBorders(bool show); > virtual void setContinuousPaintingEnabled(bool enabled); > virtual void setShowScrollBottleneckRects(bool show); > + virtual bool usesGpuRasterization() OVERRIDE; > > // cc::LayerTreeHostClient implementation. > virtual void WillBeginMainFrame(int frame_id) OVERRIDE; > Index: content/test/web_layer_tree_view_impl_for_testing.cc > diff --git a/content/test/web_layer_tree_view_impl_for_testing.cc > b/content/test/web_layer_tree_view_impl_for_testing.cc > index 11d00ee9a8551a212f614b517921d9d0225c9a3d.. > 724571cf0eec8af72324bc4e6abc015f58499d81 100644 > --- a/content/test/web_layer_tree_view_impl_for_testing.cc > +++ b/content/test/web_layer_tree_view_impl_for_testing.cc > @@ -168,4 +168,8 @@ void WebLayerTreeViewImplForTesting::clearViewportLayers() > { > scoped_refptr<cc::Layer>()); > } > > +bool WebLayerTreeViewImplForTesting::usesGpuRasterization() { > + return false; > +} > + > } // namespace content > Index: content/test/web_layer_tree_view_impl_for_testing.h > diff --git a/content/test/web_layer_tree_view_impl_for_testing.h > b/content/test/web_layer_tree_view_impl_for_testing.h > index c2b60c5e7877f05aba4ca5951d5952b486ee84fe.. > 329f37b6a079830f6b64fad322a348fe9768ab0d 100644 > --- a/content/test/web_layer_tree_view_impl_for_testing.h > +++ b/content/test/web_layer_tree_view_impl_for_testing.h > @@ -59,6 +59,7 @@ class WebLayerTreeViewImplForTesting > const blink::WebLayer* innerViewportScrollLayer, > const blink::WebLayer* outerViewportScrollLayer) OVERRIDE; > virtual void clearViewportLayers() OVERRIDE; > + virtual bool usesGpuRasterization() OVERRIDE; > > // cc::LayerTreeHostClient implementation. > virtual void WillBeginMainFrame(int frame_id) OVERRIDE {} > > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
The CQ bit was checked by chrishtr@chromium.org
The CQ bit was unchecked by chrishtr@chromium.org
+kbr for owners of content/renderer/gpu. +phajdan.jr for content/test/.
lgtm
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/326283002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15643) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18780)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/326283002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15808) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18941)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/326283002/40001
Message was sent while issue was closed.
Change committed as 276753
Message was sent while issue was closed.
A revert of this CL has been created in https://codereview.chromium.org/349733002/ by jamesr@chromium.org. The reason for reverting is: Need to revert the blink side and this (incorrectly) adds an OVERRIDE for a cross-repository override.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
