runtime/vm/parser.cc - Issue 326263002: Add missing demangling to the VM's NoSuchMethodError. Ensure the NoSuchMethorError for reflective i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 326263002: Add missing demangling to the VM's NoSuchMethodError. Ensure the NoSuchMethorError for reflective i… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: also deal with NSMEs for assignment to finals Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index 6088ed059e8031d6d30836678462eadb849843c3..0b18afbaf2bcdef7a10244e363889b3680b2ea8f 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -8053,7 +8053,7 @@ AstNode* Parser::CreateAssignmentNode(AstNode* original,

result = ThrowNoSuchMethodError(

original->token_pos(),

*target_cls,

- name,

+ String::ZoneHandle(Field::SetterName(name)),

siva 2014/06/12 16:59:07 Why does it have to be a ZoneHandle just a regular

rmacnak 2014/06/12 22:52:08 Ok, ThrowNoSuchMethod creates its own zone handle

NULL, // No arguments.

InvocationMirror::kStatic,

original->IsLoadLocalNode() ?

« runtime/lib/mirrors.cc ('K') | « runtime/lib/mirrors_patch.dart ('k') | tests/lib/lib.status » ('j') | no next file with comments »