Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 326223002: Add an LATC compressor to the A8 masks, and hide it behind an ifdef. (Closed)

Created:
6 years, 6 months ago by krajcevski
Modified:
6 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add an LATC compressor to the A8 masks, and hide it behind an ifdef. Committed: https://skia.googlesource.com/skia/+/5c2fca040ec74617644554a46c39ab038afe2f1b

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove some paranoia #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M gyp/gpu.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 4 chunks +30 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
krajcevski
6 years, 6 months ago (2014-06-10 22:10:22 UTC) #1
robertphillips
lgtm + minor stuff https://codereview.chromium.org/326223002/diff/1/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (right): https://codereview.chromium.org/326223002/diff/1/src/gpu/GrSWMaskHelper.cpp#newcode16 src/gpu/GrSWMaskHelper.cpp:16: #if GR_COMPRESS_ALPHA_MASK no extra space ...
6 years, 6 months ago (2014-06-10 22:19:46 UTC) #2
krajcevski
https://codereview.chromium.org/326223002/diff/1/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (right): https://codereview.chromium.org/326223002/diff/1/src/gpu/GrSWMaskHelper.cpp#newcode16 src/gpu/GrSWMaskHelper.cpp:16: #if GR_COMPRESS_ALPHA_MASK On 2014/06/10 22:19:46, robertphillips wrote: > no ...
6 years, 6 months ago (2014-06-10 22:28:47 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 6 months ago (2014-06-10 22:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/326223002/10001
6 years, 6 months ago (2014-06-10 22:30:36 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 00:25:35 UTC) #6
Message was sent while issue was closed. 
Change committed as 5c2fca040ec74617644554a46c39ab038afe2f1b

Powered by Google App Engine
This is Rietveld 408576698