Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3183)

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineModel.js

Issue 326063004: Correctly calculate highlighted quad for tracing based timeline events (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TracingTimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TracingTimelineModel.js b/Source/devtools/front_end/timeline/TracingTimelineModel.js
index be87ef4653700ad655d5a96f2f5dda22d125b718..cc74e169740a4203fb02b3c80cb5278dcdb65e00 100644
--- a/Source/devtools/front_end/timeline/TracingTimelineModel.js
+++ b/Source/devtools/front_end/timeline/TracingTimelineModel.js
@@ -366,6 +366,7 @@ WebInspector.TracingTimelineModel.prototype = {
var frameId = event.args["beginData"]["frame"];
event.initiator = this._layoutInvalidate[frameId];
event.backendNodeId = event.args["endData"]["rootNode"];
+ event.highlightQuad = event.args["endData"]["root"];
this._layoutInvalidate[frameId] = null;
if (this._currentScriptEvent)
event.warning = WebInspector.UIString("Forced synchronous layout is a possible performance bottleneck.");
@@ -392,6 +393,8 @@ WebInspector.TracingTimelineModel.prototype = {
break;
case recordTypes.Paint:
+ event.highlightQuad = event.args["data"]["clip"];
+ // Initionally fall through.
case recordTypes.ScrollLayer:
event.backendNodeId = event.args["data"]["nodeId"];
break;
@@ -581,6 +584,14 @@ WebInspector.TracingTimelineModel.TraceEventRecord.prototype = {
},
/**
+ * @return {?Object}
+ */
+ highlightQuad: function()
+ {
+ return this._event.highlightQuad || null;
+ },
+
+ /**
* @return {string}
*/
frameId: function()
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698