Source/devtools/front_end/timeline/TimelineView.js - Issue 326063004: Correctly calculate highlighted quad for tracing based timeline events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 326063004: Correctly calculate highlighted quad for tracing based timeline events (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed comment Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/timeline/TimelineModelImpl.js ('k') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineView.js

diff --git a/Source/devtools/front_end/timeline/TimelineView.js b/Source/devtools/front_end/timeline/TimelineView.js

index 68a7c42233c932a9884f9ae9a0570b27426a601b..8ce63661b6d03d1510a44a754f7af5331c14e810 100644

--- a/Source/devtools/front_end/timeline/TimelineView.js

+++ b/Source/devtools/front_end/timeline/TimelineView.js

@@ -829,18 +829,7 @@ WebInspector.TimelineView.prototype = {

return true;

this._highlightedQuadRecord = record;

- var quad = null;

- var recordTypes = WebInspector.TimelineModel.RecordType;

- switch(record.type()) {

- case recordTypes.Layout:

- quad = record.data().root;

- break;

- case recordTypes.Paint:

- quad = record.data().clip;

- break;

- default:

- return false;

- }

+ var quad = record.highlightQuad();

if (!quad)

return false;

record.target().domAgent().highlightQuad(quad, WebInspector.Color.PageHighlight.Content.toProtocolRGBA(), WebInspector.Color.PageHighlight.ContentOutline.toProtocolRGBA());