Issue 326063004: Correctly calculate highlighted quad for tracing based timeline events

Issue 326063004: Correctly calculate highlighted quad for tracing based timeline events (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Correctly calculate highlighted quad for tracing based timeline events highlightQuad method is added to TimelineMode.Rectord. The method encapsulates logic specific to timeline events and trace events. BUG=361045 R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175892

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -12 lines)			Patch
M	Source/devtools/front_end/timeline/TimelineModel.js	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineModelImpl.js	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineView.js	View		1 chunk	+1 line, -12 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TracingTimelineModel.js	View	1	3 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

caseq

lgtm https://codereview.chromium.org/326063004/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js File Source/devtools/front_end/timeline/TracingTimelineModel.js (right): https://codereview.chromium.org/326063004/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode369 Source/devtools/front_end/timeline/TracingTimelineModel.js:369: event.clip = event.args["endData"]["root"]; I'd rather not use clip, ...

6 years, 6 months ago (2014-06-10 13:21:23 UTC) #2

yurys

https://codereview.chromium.org/326063004/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js File Source/devtools/front_end/timeline/TracingTimelineModel.js (right): https://codereview.chromium.org/326063004/diff/1/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode369 Source/devtools/front_end/timeline/TracingTimelineModel.js:369: event.clip = event.args["endData"]["root"]; On 2014/06/10 13:21:23, caseq wrote: > ...

6 years, 6 months ago (2014-06-10 13:25:37 UTC) #3

yurys

6 years, 6 months ago (2014-06-10 13:31:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r175892 (presubmit successful).

Expand Messages | Collapse Messages