App list: TileItemView::SetAppListItem exits early if item already set.

ui/app_list/views/tile_item_view.cc

Index: ui/app_list/views/tile_item_view.cc
diff --git a/ui/app_list/views/tile_item_view.cc b/ui/app_list/views/tile_item_view.cc
index 583098e25cad9b879cba0a5c81e3e3b64971df96..c6d5f1cc717932312aad1ffa5867b9407b71a7dc 100644
--- a/ui/app_list/views/tile_item_view.cc
+++ b/ui/app_list/views/tile_item_view.cc
@@ -102,6 +102,9 @@ TileItemView::~TileItemView() {
 }
 
 void TileItemView::SetAppListItem(AppListItem* item) {
+  if (item == item_)

[tapted, 2014/06/10 04:21:54]

Does the pointer change when just the title/icon changes via sync?

void ExtensionAppModelBuilder::OnExtensionLoaded(..) suggests: probably not.

But if everyone is OK with that regressing until phase 2, I think that's fine
while experimental. (but maybe a TODO here: ~implement AppListItemObserver to
detect icon/title changes.

[Matt Giuca, 2014/06/10 05:28:54]

Done (TODO).

Calamity says not worth addressing now since it's going to change to a different
base class, but we should address it once it has been refactored.

+    return;
+
   item_ = item;
   if (!item) {
     SetVisible(false);
@@ -127,4 +130,4 @@ void TileItemView::ButtonPressed(views::Button* sender,
   item_->Activate(event.flags());
 }
 
-}  // namespace app_list
+}  // namespace app_list