App list: TileItemView::SetAppListItem exits early if item already set.

ui/app_list/views/tile_item_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/tile_item_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/app_list/app_list_constants.h"
 #include "ui/app_list/app_list_item.h"
 #include "ui/app_list/app_list_model.h"
@@ skipping 84 matching lines @@
   title_->SetHorizontalAlignment(gfx::ALIGN_CENTER);
 
   AddChildView(icon_);
   AddChildView(title_);
 }
 
 TileItemView::~TileItemView() {
 }
 
 void TileItemView::SetAppListItem(AppListItem* item) {
+  if (item == item_)

[tapted, 2014/06/10 04:21:54]

Does the pointer change when just the title/icon changes via sync?

void ExtensionAppModelBuilder::OnExtensionLoaded(..) suggests: probably not.

But if everyone is OK with that regressing until phase 2, I think that's fine
while experimental. (but maybe a TODO here: ~implement AppListItemObserver to
detect icon/title changes.

[Matt Giuca, 2014/06/10 05:28:54]

Done (TODO).

Calamity says not worth addressing now since it's going to change to a different
base class, but we should address it once it has been refactored.

+    return;
+
   item_ = item;
   if (!item) {
     SetVisible(false);
     icon_->SetImage(NULL);
     title_->SetText(base::string16());
     return;
   }
 
   SetVisible(true);
   icon_->SetImage(item_->icon());
   title_->SetText(base::UTF8ToUTF16(item_->name()));
 
   background_->set_strip_color(
       color_utils::CalculateKMeanColorOfBitmap(*item_->icon().bitmap()));
 }
 
 gfx::Size TileItemView::GetPreferredSize() const {
   return gfx::Size(kTileSize, kTileSize);
 }
 
 void TileItemView::ButtonPressed(views::Button* sender,
                                  const ui::Event& event) {
   item_->Activate(event.flags());
 }
 
-}  // namespace app_list
+}  // namespace app_list