Do not append Google locale to help center links

Do not append Google locale to help center links

This CL eliminates the appending of the Google locale to all "learnMore" and
"help" URLs.

BUG=164939
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276616

[blundell, 2014-06-10 15:20:23]

Hey Peter,

Do you know who to ping to make sure that this is desired behavior?

Thanks,

Colin

[Peter Kasting, 2014-06-10 18:51:10]

On 2014/06/10 15:20:23, blundell wrote:
> Do you know who to ping to make sure that this is desired behavior?

Try mwhill@.

[Peter Kasting, 2014-06-10 18:58:25]

So, do we still have other callers of this?

LGTM

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/ash/system...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/ash/system...
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:588: GURL
url(chrome::kLearnMoreEnterpriseURL);
Nit: Could inline below

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc:39: browser_,
Nit: This can now go on the end of the previous line (and the next two lines be
indented even)

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:84: base::string16
GetUrlWithLang(const GURL& url) {
This name is now misleading as we don't do anything language-related here.

We may even be able to eliminate this helper entirely if the callers can be
changed to UTF-8 versions, allowing us to just inline "url.spec()" at the
callsites.

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:107:
"clearBrowsingDataLearnMoreUrl", kClearBrowsingDataLearnMoreUrl);
Nit: I have a slight preference for

  localized_strings->SetString("clearBrowsingDataLearnMoreUrl",
                               kClearBrowsingDataLearnMoreUrl);

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:464:
"exceptionsLearnMoreUrl", kExceptionsLearnMoreUrl);
Nit: Same nit

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/handler_options_handler.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/handler_options_handler.cc:57:
"handlers_learn_more_url", kHandlersLearnMoreUrl);
Nit: Same nit

[blundell, 2014-06-10 19:04:21]

On 2014/06/10 18:58:25, Peter Kasting wrote:
> So, do we still have other callers of this?
> 

Yes, there are still ~10 other callers. My plan was to write a CL changing
AppendGoogleLocale...() to take in the application locale, change those callers,
and then we could decide in looking at the CL which if any of the callers didn't
need to be appending the locale anymore.

> LGTM
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/ash/system...
> File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right):
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/ash/system...
> chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:588: GURL
> url(chrome::kLearnMoreEnterpriseURL);
> Nit: Could inline below
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/browser_co...
> File chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc
(right):
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/browser_co...
> chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc:39:
browser_,
> Nit: This can now go on the end of the previous line (and the next two lines
be
> indented even)
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/ntp/...
> File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/ntp/...
> chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:84: base::string16
> GetUrlWithLang(const GURL& url) {
> This name is now misleading as we don't do anything language-related here.
> 
> We may even be able to eliminate this helper entirely if the callers can be
> changed to UTF-8 versions, allowing us to just inline "url.spec()" at the
> callsites.
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
> File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
> chrome/browser/ui/webui/options/clear_browser_data_handler.cc:107:
> "clearBrowsingDataLearnMoreUrl", kClearBrowsingDataLearnMoreUrl);
> Nit: I have a slight preference for
> 
>   localized_strings->SetString("clearBrowsingDataLearnMoreUrl",
>                                kClearBrowsingDataLearnMoreUrl);
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
> File chrome/browser/ui/webui/options/content_settings_handler.cc (right):
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
> chrome/browser/ui/webui/options/content_settings_handler.cc:464:
> "exceptionsLearnMoreUrl", kExceptionsLearnMoreUrl);
> Nit: Same nit
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
> File chrome/browser/ui/webui/options/handler_options_handler.cc (right):
> 
>
https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
> chrome/browser/ui/webui/options/handler_options_handler.cc:57:
> "handlers_learn_more_url", kHandlersLearnMoreUrl);
> Nit: Same nit

[Peter Kasting, 2014-06-10 21:05:59]

There still seems to be a usage for a support article in e.g.
components/google/core/browser/google_url_tracker_infobar_delegate.cc (which in
turn necessitates all the GoogleURLTrackerClient::AppendGoogleLocaleParam()
plumbing).  That should all be removed.

[blundell, 2014-06-11 12:07:20]

TBR=sky for //chrome OWNERS

Removed the usage in GoogleURLTrackerInfoBarDelegate.

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/ash/system...
File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/ash/system...
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:588: GURL
url(chrome::kLearnMoreEnterpriseURL);
On 2014/06/10 18:58:25, Peter Kasting wrote:
> Nit: Could inline below

Done.

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc:39: browser_,
On 2014/06/10 18:58:25, Peter Kasting wrote:
> Nit: This can now go on the end of the previous line (and the next two lines
be
> indented even)

Done.

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:84: base::string16
GetUrlWithLang(const GURL& url) {
On 2014/06/10 18:58:25, Peter Kasting wrote:
> This name is now misleading as we don't do anything language-related here.
> 
> We may even be able to eliminate this helper entirely if the callers can be
> changed to UTF-8 versions, allowing us to just inline "url.spec()" at the
> callsites.

Done.

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:107:
"clearBrowsingDataLearnMoreUrl", kClearBrowsingDataLearnMoreUrl);
On 2014/06/10 18:58:25, Peter Kasting wrote:
> Nit: I have a slight preference for
> 
>   localized_strings->SetString("clearBrowsingDataLearnMoreUrl",
>                                kClearBrowsingDataLearnMoreUrl);

Done.

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/content_settings_handler.cc:464:
"exceptionsLearnMoreUrl", kExceptionsLearnMoreUrl);
On 2014/06/10 18:58:25, Peter Kasting wrote:
> Nit: Same nit

Done.

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/handler_options_handler.cc (right):

https://codereview.chromium.org/325963007/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/handler_options_handler.cc:57:
"handlers_learn_more_url", kHandlersLearnMoreUrl);
On 2014/06/10 18:58:25, Peter Kasting wrote:
> Nit: Same nit

Done.

[blundell, 2014-06-11 12:07:26]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-11 12:09:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/325963007/20001

[commit-bot: I haz the power, 2014-06-11 20:59:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:14:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:14:48]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[blundell, 2014-06-12 05:18:07]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-12 05:20:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/325963007/20001

[commit-bot: I haz the power, 2014-06-12 10:25:35]

Change committed as 276616