Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: chrome/browser/ui/webui/options/handler_options_handler.cc

Issue 325963007: Do not append Google locale to help center links (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/handler_options_handler.h" 5 #include "chrome/browser/ui/webui/options/handler_options_handler.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 { "handlers_remove_link", IDS_HANDLERS_REMOVE_HANDLER_LINK }, 47 { "handlers_remove_link", IDS_HANDLERS_REMOVE_HANDLER_LINK },
48 { "handlers_none_handler", IDS_HANDLERS_NONE_HANDLER }, 48 { "handlers_none_handler", IDS_HANDLERS_NONE_HANDLER },
49 { "handlers_active_heading", IDS_HANDLERS_ACTIVE_HEADING }, 49 { "handlers_active_heading", IDS_HANDLERS_ACTIVE_HEADING },
50 { "handlers_ignored_heading", IDS_HANDLERS_IGNORED_HEADING }, 50 { "handlers_ignored_heading", IDS_HANDLERS_IGNORED_HEADING },
51 }; 51 };
52 RegisterTitle(localized_strings, "handlersPage", 52 RegisterTitle(localized_strings, "handlersPage",
53 IDS_HANDLER_OPTIONS_WINDOW_TITLE); 53 IDS_HANDLER_OPTIONS_WINDOW_TITLE);
54 RegisterStrings(localized_strings, resources, arraysize(resources)); 54 RegisterStrings(localized_strings, resources, arraysize(resources));
55 55
56 localized_strings->SetString( 56 localized_strings->SetString(
57 "handlers_learn_more_url", 57 "handlers_learn_more_url", kHandlersLearnMoreUrl);
Peter Kasting 2014/06/10 18:58:25 Nit: Same nit
blundell 2014/06/11 12:07:19 Done.
58 google_util::StringAppendGoogleLocaleParam(kHandlersLearnMoreUrl));
59 } 58 }
60 59
61 void HandlerOptionsHandler::InitializeHandler() { 60 void HandlerOptionsHandler::InitializeHandler() {
62 notification_registrar_.Add( 61 notification_registrar_.Add(
63 this, chrome::NOTIFICATION_PROTOCOL_HANDLER_REGISTRY_CHANGED, 62 this, chrome::NOTIFICATION_PROTOCOL_HANDLER_REGISTRY_CHANGED,
64 content::Source<Profile>(Profile::FromWebUI(web_ui()))); 63 content::Source<Profile>(Profile::FromWebUI(web_ui())));
65 } 64 }
66 65
67 void HandlerOptionsHandler::InitializePage() { 66 void HandlerOptionsHandler::InitializePage() {
68 UpdateHandlerList(); 67 UpdateHandlerList();
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 int type, 209 int type,
211 const content::NotificationSource& source, 210 const content::NotificationSource& source,
212 const content::NotificationDetails& details) { 211 const content::NotificationDetails& details) {
213 if (type == chrome::NOTIFICATION_PROTOCOL_HANDLER_REGISTRY_CHANGED) 212 if (type == chrome::NOTIFICATION_PROTOCOL_HANDLER_REGISTRY_CHANGED)
214 UpdateHandlerList(); 213 UpdateHandlerList();
215 else 214 else
216 NOTREACHED(); 215 NOTREACHED();
217 } 216 }
218 217
219 } // namespace options 218 } // namespace options
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698