Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 325933003: Scroll offset pinning and content size notifications were only used for the Mac overlay navigation … (Closed)

Created:
6 years, 6 months ago by Avi (use Gerrit)
Modified:
6 years, 6 months ago
Reviewers:
jam, nasko
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Scroll offset pinning and content size notifications were only used for the Mac overlay navigation code, which no longer needs them as of r274906. Remove them. BUG=321437 TEST=everything still compiles and works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -176 lines) Patch
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 5 chunks +0 lines, -31 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/public/browser/render_widget_host_view_mac_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
https://codereview.chromium.org/322793004 is the Blink half. Nasko: IPC John: everything else
6 years, 6 months ago (2014-06-09 23:02:45 UTC) #1
nasko
IPC LGTM
6 years, 6 months ago (2014-06-09 23:13:16 UTC) #2
jam
lgtm
6 years, 6 months ago (2014-06-10 05:48:59 UTC) #3
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 6 months ago (2014-06-10 14:31:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/325933003/1
6 years, 6 months ago (2014-06-10 14:35:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 22:43:56 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 00:32:16 UTC) #7
Message was sent while issue was closed. 
Change committed as 276217

Powered by Google App Engine
This is Rietveld 408576698