Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 322793004: Content size notification was only used for the Mac overlay navigation code, which no longer needs … (Closed)

Created:
6 years, 6 months ago by Avi (use Gerrit)
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Content size notification was only used for the Mac overlay navigation code, which no longer needs it as of Chromium r274906. Remove it. BUG=321437 TEST=everything still compiles and works. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
https://codereview.chromium.org/325933003 is the Chromium half.
6 years, 6 months ago (2014-06-09 23:01:37 UTC) #1
dglazkov
lgtm
6 years, 6 months ago (2014-06-10 04:47:24 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 6 months ago (2014-06-10 04:59:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/322793004/1
6 years, 6 months ago (2014-06-10 05:00:06 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 06:05:29 UTC) #5
Message was sent while issue was closed.
Change committed as 175861

Powered by Google App Engine
This is Rietveld 408576698