Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 32583003: Remove HTMLMediaElement.startTime (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, nessy, feature-media-reviews_chromium.org, dglazkov+blink, Inactive, vcarbune.chromium, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@mediaidl
Visibility:
Public.

Description

Remove HTMLMediaElement.startTime It was replaced with initialTime in August 2010: http://html5.org/r/5310 BUG=309473 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -52 lines) Patch
D LayoutTests/media/media-startTime.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/media/media-startTime-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
7 years, 2 months ago (2013-10-21 19:29:57 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-21 20:25:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/32583003/1
7 years, 2 months ago (2013-10-21 20:26:16 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLMediaElement.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-21 20:26:19 UTC) #4
philipj_slow
This patch depends on <https://codereview.chromium.org/32103002/>, have to wait for that to be committed first...
7 years, 2 months ago (2013-10-21 20:48:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/32583003/1
7 years, 2 months ago (2013-10-22 04:54:13 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 09:46:14 UTC) #7
Message was sent while issue was closed.
Change committed as 160174

Powered by Google App Engine
This is Rietveld 408576698