Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 32103002: Use MeasureAs and ImplementedAs in media IDL (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, nessy, feature-media-reviews_chromium.org, dglazkov+blink, Inactive, vcarbune.chromium, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use MeasureAs and ImplementedAs in media IDL This leaves the C++ code a little bit cleaner. Also indent HTMLMediaElement.idl for consistency. BUG=309364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160119

Patch Set 1 #

Patch Set 2 : accidentally dropped two UseCounters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -92 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +61 lines, -61 lines 0 comments Download
M Source/core/html/HTMLVideoElement.h View 2 chunks +2 lines, -10 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 4 chunks +2 lines, -11 lines 0 comments Download
M Source/core/html/HTMLVideoElement.idl View 1 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
Found some IDL features to clean up my two previous patches.
7 years, 2 months ago (2013-10-21 09:22:37 UTC) #1
philipj_slow
Found some IDL features to clean up my two previous patches.
7 years, 2 months ago (2013-10-21 09:22:37 UTC) #2
Mike West
LGTM. This is a nice improvement, thank you. :)
7 years, 2 months ago (2013-10-21 12:37:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/32103002/40001
7 years, 2 months ago (2013-10-21 12:44:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12665
7 years, 2 months ago (2013-10-21 15:02:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/32103002/40001
7 years, 2 months ago (2013-10-21 16:53:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12781
7 years, 2 months ago (2013-10-21 20:43:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/32103002/40001
7 years, 2 months ago (2013-10-21 20:47:29 UTC) #8
eseidel
lgtm
7 years, 2 months ago (2013-10-21 20:49:10 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 01:33:23 UTC) #10
Message was sent while issue was closed. 
Change committed as 160119

Powered by Google App Engine
This is Rietveld 408576698