Issue 325703002: second try at landing improved blur rect

Issue 325703002: second try at landing improved blur rect (Closed)

Created:
6 years, 6 months ago by humper

Modified:
6 years, 6 months ago

Reviewers:
bsalomon, reed2

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

second try at landing improved blur rect BUG=skia:2095 TBR=bsalomon Committed: https://skia.googlesource.com/skia/+/e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76

Patch Set 2 : Temporarily enable shader printing so I can see what's going on #

Patch Set 3 : remove debug stuff and make sure to modulate the blur rect output by the input source color #

Patch Set 4 : rebase #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -101 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	1 2	8 chunks	+97 lines, -94 lines	2 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/BlurTest.cpp	View		4 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/325703002/60001

6 years, 6 months ago (2014-06-09 20:55:19 UTC) #2

commit-bot: I haz the power

Change committed as e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76

6 years, 6 months ago (2014-06-09 21:35:28 UTC) #3

reed2

https://codereview.chromium.org/325703002/diff/60001/src/effects/SkBlurMaskFilter.cpp File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/325703002/diff/60001/src/effects/SkBlurMaskFilter.cpp#newcode561 src/effects/SkBlurMaskFilter.cpp:561: int doubleProfileSize = SkScalarCeilToInt(12*sigma); dox on this formula? https://codereview.chromium.org/325703002/diff/60001/src/effects/SkBlurMaskFilter.cpp#newcode799 ...

6 years, 6 months ago (2014-06-10 01:15:50 UTC) #4

reed1

6 years, 6 months ago (2014-06-11 14:25:23 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/322423002/ by reed@google.com.

The reason for reverting is: broke some fast/canvas layout tests.

Expand Messages | Collapse Messages