[mac] Support adding the launcher to the Dock when Dashboard.app is present.

chrome/browser/web_applications/web_app_mac.mm

Index: chrome/browser/web_applications/web_app_mac.mm
diff --git a/chrome/browser/web_applications/web_app_mac.mm b/chrome/browser/web_applications/web_app_mac.mm
index 098b432d0e834bd06496542c89c6ad131dbac433..bc4230dbbcee606bb77b34c45bdde77bb324f700 100644
--- a/chrome/browser/web_applications/web_app_mac.mm
+++ b/chrome/browser/web_applications/web_app_mac.mm
@@ -490,8 +490,18 @@ bool WebAppShortcutCreator::CreateShortcuts(
   if (success_count != paths.size())
     return false;
 
-  if (creation_locations.in_quick_launch_bar && path_to_add_to_dock)
-    dock::AddIcon(path_to_add_to_dock, nil);
+  if (creation_locations.in_quick_launch_bar && path_to_add_to_dock) {
+    switch (dock::AddIcon(path_to_add_to_dock, nil)) {
+      case dock::IconAddFailure:
+        // If adding the icon failed, instead reveal the Finder window.
+        RevealAppShimInFinder();
+        break;
+      case dock::IconAddSuccess:
+      case dock::IconAlreadyPresent:
+        break;
+    }
+    return true;
+  }

[Nico, 2013/10/23 00:21:11]

I don't understand this part of the change. Why is this part of the CL? Why is
opening the app shim in finder on "create shortcut" a desired ui flow?

[tapted, 2013/10/23 00:59:24]

Yeah - hopefully this UI flow can be avoided.

With this change, if it's clear that adding the App Launcher tile to the Dock
failed, opening a Finder window with the shortcut highlighted gives someone an
opportunity to drag it in themselves. Initial feedback had a few people caught
by the bug confused; hunting for the launcher icon that was in the webstore
messaging. With this fix, hopefully any remaining cases will be very rare (but
following up with some UMA might be a good idea... - made
http://crbug.com/310388 ).

For normal installs the flow shouldn't be hit. But, the messaging is controlled
server-side. So (hypothetically) if a Mac point release was to break this
suddenly, different instructions could be shown, based on user agent. That's not
ideal, but Apple seem to want it to be hard to add things to the Dock -- there
was a nice CoreDock private API that got disabled in Lion, but this flow still
works.

 
   if (creation_reason == SHORTCUT_CREATION_BY_USER)
     RevealAppShimInFinder();