Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 325363002: Fix BrowserMediaPlayerManager and BrowserCdmManager destruction order. (Closed)

Created:
6 years, 6 months ago by xhwang
Modified:
6 years, 6 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix BrowserMediaPlayerManager and BrowserCdmManager destruction order. The order was reverted accidentally in r276200 which was wrong. BUG=315312 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276657

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M content/browser/media/media_web_contents_observer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/android/media_source_player.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
xhwang
PTAL
6 years, 6 months ago (2014-06-11 23:22:51 UTC) #1
qinmin
lgtm % nit https://codereview.chromium.org/325363002/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (right): https://codereview.chromium.org/325363002/diff/1/media/base/android/media_source_player.cc#newcode753 media/base/android/media_source_player.cc:753: drm_bridge_ = NULL; nit: also need ...
6 years, 6 months ago (2014-06-11 23:36:25 UTC) #2
xhwang
comments addressed
6 years, 6 months ago (2014-06-11 23:42:23 UTC) #3
xhwang
https://codereview.chromium.org/325363002/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (right): https://codereview.chromium.org/325363002/diff/1/media/base/android/media_source_player.cc#newcode753 media/base/android/media_source_player.cc:753: drm_bridge_ = NULL; On 2014/06/11 23:36:25, qinmin wrote: > ...
6 years, 6 months ago (2014-06-11 23:42:30 UTC) #4
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 6 months ago (2014-06-11 23:42:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/325363002/20001
6 years, 6 months ago (2014-06-11 23:44:36 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 01:08:29 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 02:17:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/28140)
6 years, 6 months ago (2014-06-12 02:17:13 UTC) #9
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 6 months ago (2014-06-12 02:19:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/325363002/20001
6 years, 6 months ago (2014-06-12 02:21:36 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 13:19:09 UTC) #12
Message was sent while issue was closed.
Change committed as 276657

Powered by Google App Engine
This is Rietveld 408576698