Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: media/base/android/media_source_player.cc

Issue 325363002: Fix BrowserMediaPlayerManager and BrowserCdmManager destruction order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments addressed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/media/media_web_contents_observer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/android/media_source_player.h" 5 #include "media/base/android/media_source_player.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 if (!is_waiting_for_key_) 737 if (!is_waiting_for_key_)
738 return; 738 return;
739 739
740 is_waiting_for_key_ = false; 740 is_waiting_for_key_ = false;
741 if (playing_) 741 if (playing_)
742 StartInternal(); 742 StartInternal();
743 } 743 }
744 744
745 void MediaSourcePlayer::OnCdmUnset() { 745 void MediaSourcePlayer::OnCdmUnset() {
746 DVLOG(1) << __FUNCTION__; 746 DVLOG(1) << __FUNCTION__;
747 // TODO(xhwang): Support detachment of CDM. This will be needed when we start
748 // to support setMediaKeys(0) (see http://crbug.com/330324), or when we
749 // release MediaDrm when the video is paused, or when the device goes to
750 // sleep (see http://crbug.com/272421).
751 NOTREACHED() << "CDM detachment not supported.";
747 DCHECK(drm_bridge_); 752 DCHECK(drm_bridge_);
748 // TODO(xhwang): Support detachment of CDM. This will be needed when we start 753 audio_decoder_job_->SetDrmBridge(NULL);
749 // to support setMediaKeys(0), or when we release MediaDrm when the video is 754 video_decoder_job_->SetDrmBridge(NULL);
750 // paused, or when the device goes to sleep. See http://crbug.com/272421 755 drm_bridge_ = NULL;
751 DVLOG(1) << "CDM detachment not supported.";
752 } 756 }
753 757
754 } // namespace media 758 } // namespace media
OLDNEW
« no previous file with comments | « content/browser/media/media_web_contents_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698