Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 325313003: Add vendor id and custom display name to media selection (Closed)

Created:
6 years, 6 months ago by Aleksey Shlyapnikov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Changes in printer settings: * add vendor id and custom display name to media selection * propagate selected media size in PrintSettings Related Сhanges in JS: * Use media custom diaply name received from the native layer * Make sure media size selection is propagated to the native layer BUG=239879 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276578

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address cl comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -30 lines) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.js View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cloud_print/cloud_print_cdd_conversion.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/cloud_devices/common/printer_description.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/cloud_devices/common/printer_description.cc View 1 4 chunks +6 lines, -2 lines 0 comments Download
M components/cloud_devices/common/printer_description_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M printing/print_job_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_job_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M printing/print_settings.h View 3 chunks +26 lines, -0 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_settings_initializer.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M printing/printing_context.cc View 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Aleksey Shlyapnikov
6 years, 6 months ago (2014-06-11 23:57:01 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/325313003/diff/1/components/cloud_devices/common/printer_description.cc File components/cloud_devices/common/printer_description.cc (right): https://codereview.chromium.org/325313003/diff/1/components/cloud_devices/common/printer_description.cc#newcode767 components/cloud_devices/common/printer_description.cc:767: dict->SetString(kKeyName, TypeToString(kMediaDefinitions, option.type)); if (option.type != CUSTOM_MEDIA)
6 years, 6 months ago (2014-06-12 00:43:24 UTC) #2
Aleksey Shlyapnikov
https://codereview.chromium.org/325313003/diff/1/components/cloud_devices/common/printer_description.cc File components/cloud_devices/common/printer_description.cc (right): https://codereview.chromium.org/325313003/diff/1/components/cloud_devices/common/printer_description.cc#newcode767 components/cloud_devices/common/printer_description.cc:767: dict->SetString(kKeyName, TypeToString(kMediaDefinitions, option.type)); On 2014/06/12 00:43:24, Vitaly Buka wrote: ...
6 years, 6 months ago (2014-06-12 00:50:05 UTC) #3
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 6 months ago (2014-06-12 00:50:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/325313003/20001
6 years, 6 months ago (2014-06-12 00:51:58 UTC) #5
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 06:57:25 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 06:57:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/325313003/20001
6 years, 6 months ago (2014-06-12 07:02:51 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 07:53:44 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-12 07:53:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/325313003/20001
6 years, 6 months ago (2014-06-12 07:59:02 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 08:08:15 UTC) #12
Message was sent while issue was closed. 
Change committed as 276578

Powered by Google App Engine
This is Rietveld 408576698