chrome/browser/resources/print_preview/settings/media_size_settings.js - Issue 325313003: Add vendor id and custom display name to media selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/media_size_settings.js

Issue 325313003: Add vendor id and custom display name to media selection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address cl comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/native_layer.js ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/media_size_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/media_size_settings.js b/chrome/browser/resources/print_preview/settings/media_size_settings.js

index 507fd935e1a123791f1573276e99b06b9487500d..445125305f11e352dda942a032c2a5d6ff96cb44 100644

--- a/chrome/browser/resources/print_preview/settings/media_size_settings.js

+++ b/chrome/browser/resources/print_preview/settings/media_size_settings.js

@@ -77,16 +77,17 @@ cr.define('print_preview', function() {

indexToSelect = index;

}

});

- } else {

- var valueToSelect = JSON.stringify(this.ticketItem_.getValue());

- for (var i = 0, option; option = select.options[i]; i++) {

- if (option.value == valueToSelect) {

- indexToSelect = i;

- break;

- }

+ }

+ // Try to select current ticket item.

+ var valueToSelect = JSON.stringify(this.ticketItem_.getValue());

+ for (var i = 0, option; option = select.options[i]; i++) {

+ if (option.value == valueToSelect) {

+ indexToSelect = i;

+ break;

}

select.selectedIndex = indexToSelect;

+ this.onSelectChange_();

/**