Consolidate Glyph and GlyphBufferGlyph.

Consolidate Glyph and GlyphBufferGlyph.

These are always equivalent since the WinCE case was dropped over a year ago:
https://chromiumcodereview.appspot.com/13901012

BUG=383594
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176039

[jbroman, 2014-06-11 22:14:58]

This seems like a straightforward simplification.

Windows trybot failures are due to ongoing infra problems.

[eae, 2014-06-12 15:58:08]

Very nice, LGTM!

[eae, 2014-06-12 15:58:11]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-06-12 15:58:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbroman@chromium.org/325283002/1

[commit-bot: I haz the power, 2014-06-12 15:59:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 15:59:04]

Failed to apply patch for Source/platform/fonts/SimpleFontData.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/fonts/SimpleFontData.h
  Hunk #1 FAILED at 167.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/platform/fonts/SimpleFontData.h.rej

Patch:       Source/platform/fonts/SimpleFontData.h
Index: Source/platform/fonts/SimpleFontData.h
diff --git a/Source/platform/fonts/SimpleFontData.h
b/Source/platform/fonts/SimpleFontData.h
index
647e55a8d946230d238bfc14448804c11521d2c8..81947f07f2b9e9cba8b7e58f1874351d093ee2a3
100644
--- a/Source/platform/fonts/SimpleFontData.h
+++ b/Source/platform/fonts/SimpleFontData.h
@@ -167,7 +167,7 @@ public:
 
     bool canRenderCombiningCharacterSequence(const UChar*, size_t) const;
 
-    bool applyTransforms(GlyphBufferGlyph*, GlyphBufferAdvance*, size_t,
TypesettingFeatures) const
+    bool applyTransforms(Glyph*, GlyphBufferAdvance*, size_t,
TypesettingFeatures) const
     {
         return false;
     }

[jbroman, 2014-06-12 16:04:49]

On 2014/06/12 15:59:04, I haz the power (commit-bot) wrote:
> Failed to apply patch for Source/platform/fonts/SimpleFontData.h:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file Source/platform/fonts/SimpleFontData.h
>   Hunk #1 FAILED at 167.
>   1 out of 1 hunk FAILED -- saving rejects to file
> Source/platform/fonts/SimpleFontData.h.rej
> 
> Patch:       Source/platform/fonts/SimpleFontData.h
> Index: Source/platform/fonts/SimpleFontData.h
> diff --git a/Source/platform/fonts/SimpleFontData.h
> b/Source/platform/fonts/SimpleFontData.h
> index
>
647e55a8d946230d238bfc14448804c11521d2c8..81947f07f2b9e9cba8b7e58f1874351d093ee2a3
> 100644
> --- a/Source/platform/fonts/SimpleFontData.h
> +++ b/Source/platform/fonts/SimpleFontData.h
> @@ -167,7 +167,7 @@ public:
>  
>      bool canRenderCombiningCharacterSequence(const UChar*, size_t) const;
>  
> -    bool applyTransforms(GlyphBufferGlyph*, GlyphBufferAdvance*, size_t,
> TypesettingFeatures) const
> +    bool applyTransforms(Glyph*, GlyphBufferAdvance*, size_t,
> TypesettingFeatures) const
>      {
>          return false;
>      }

Collided with myself; will rebase.

[jbroman, 2014-06-12 16:09:13]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:10:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbroman@chromium.org/325283002/20001

[commit-bot: I haz the power, 2014-06-12 17:16:05]

Change committed as 176039