Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp - Issue 325283002: Consolidate Glyph and GlyphBufferGlyph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

Issue 325283002: Consolidate Glyph and GlyphBufferGlyph. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

diff --git a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

index ab5a45cea5b9a92dff994996a4aa0c968dd154a8..a4f6854e804950ee3e9ea1dd7c6ec3092114d01a 100644

--- a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

+++ b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

@@ -1001,7 +1001,7 @@ void HarfBuzzShaper::fillGlyphBufferForTextEmphasis(GlyphBuffer* glyphBuffer, Ha

float glyphAdvanceX = clusterAdvance / graphemesInCluster;

for (unsigned j = 0; j < graphemesInCluster; ++j) {

// Do not put emphasis marks on space, separator, and control characters.

- GlyphBufferGlyph glyphToAdd = Character::canReceiveTextEmphasis(m_run[currentCharacterIndex]) ? 1 : 0;

+ Glyph glyphToAdd = Character::canReceiveTextEmphasis(m_run[currentCharacterIndex]) ? 1 : 0;

glyphBuffer->add(glyphToAdd, currentRun->fontData(), createGlyphBufferAdvance(glyphAdvanceX, 0));

}

clusterStart = clusterEnd;