Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 325213004: Mojo: Wrap the satisfied/unsatisfied wait flags state in a single object. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Wrap the satisfied/unsatisfied wait flags state in a single object. First, add a struct (MojoWaitFlagsState) to the public C API. We'll use this to report additional (e.g., per-handle) information in MojoWait()/MojoWaitMany(). Second, make a subclass struct (mojo::system::WaitFlagsState) that adds a constructor and some simple methods for convenience (but adding no overhead). Third, convert our various separate handling of satisfied/satisfiable state to use the new combined struct. R=sky@chromium.org, darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -165 lines) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/c/system/types.h View 2 chunks +13 lines, -0 lines 0 comments Download
M mojo/system/data_pipe.h View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/system/data_pipe.cc View 11 chunks +26 lines, -18 lines 0 comments Download
M mojo/system/local_data_pipe.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/system/local_data_pipe.cc View 2 chunks +17 lines, -24 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 5 chunks +21 lines, -33 lines 0 comments Download
M mojo/system/platform_handle_dispatcher.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/system/platform_handle_dispatcher.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M mojo/system/simple_dispatcher.h View 2 chunks +7 lines, -11 lines 0 comments Download
M mojo/system/simple_dispatcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 2 chunks +19 lines, -21 lines 0 comments Download
A mojo/system/wait_flags_state.h View 1 chunk +48 lines, -0 lines 0 comments Download
M mojo/system/waiter_list.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/system/waiter_list.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M mojo/system/waiter_list_unittest.cc View 12 chunks +29 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 6 months ago (2014-06-11 20:14:36 UTC) #1
viettrungluu
-> sky instead
6 years, 6 months ago (2014-06-11 20:47:28 UTC) #2
sky
LGTM
6 years, 6 months ago (2014-06-11 21:21:37 UTC) #3
viettrungluu
Committed patchset #1 manually as r276708 (presubmit successful).
6 years, 6 months ago (2014-06-12 16:31:22 UTC) #4
darin (slow to review)
6 years, 6 months ago (2014-06-12 16:38:34 UTC) #5
Message was sent while issue was closed.
LGTM2

Powered by Google App Engine
This is Rietveld 408576698