Mojo: Wrap the satisfied/unsatisfied wait flags state in a single object.

mojo/system/simple_dispatcher_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NOTE(vtl): Some of these tests are inherently flaky (e.g., if run on a
 // heavily-loaded system). Sorry. |test::EpsilonTimeout()| may be increased to
 // increase tolerance and reduce observed flakiness (though doing so reduces the
 // meaningfulness of the test).
 
 #include "mojo/system/simple_dispatcher.h"
@@ skipping 10 matching lines @@
 #include "mojo/system/waiter_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace mojo {
 namespace system {
 namespace {
 
 class MockSimpleDispatcher : public SimpleDispatcher {
  public:
   MockSimpleDispatcher()
-      : satisfied_flags_(MOJO_WAIT_FLAG_NONE),
-        satisfiable_flags_(MOJO_WAIT_FLAG_READABLE | MOJO_WAIT_FLAG_WRITABLE) {}
+      : state_(MOJO_WAIT_FLAG_NONE,
+               MOJO_WAIT_FLAG_READABLE | MOJO_WAIT_FLAG_WRITABLE) {}
 
   void SetSatisfiedFlags(MojoWaitFlags new_satisfied_flags) {
     base::AutoLock locker(lock());
 
     // Any new flags that are set should be satisfiable.
-    CHECK_EQ(new_satisfied_flags & ~satisfied_flags_,
-             new_satisfied_flags & ~satisfied_flags_ & satisfiable_flags_);
+    CHECK_EQ(new_satisfied_flags & ~state_.satisfied_flags,
+             new_satisfied_flags & ~state_.satisfied_flags &
+                 state_.satisfiable_flags);
 
-    if (new_satisfied_flags == satisfied_flags_)
+    if (new_satisfied_flags == state_.satisfied_flags)
       return;
 
-    satisfied_flags_ = new_satisfied_flags;
-    StateChangedNoLock();
+    state_.satisfied_flags = new_satisfied_flags;
+    WaitFlagsStateChangedNoLock();
   }
 
   void SetSatisfiableFlags(MojoWaitFlags new_satisfiable_flags) {
     base::AutoLock locker(lock());
 
-    if (new_satisfiable_flags == satisfiable_flags_)
+    // Satisfied implies satisfiable.
+    CHECK_EQ(new_satisfiable_flags & state_.satisfied_flags,
+             state_.satisfied_flags);
+
+    if (new_satisfiable_flags == state_.satisfiable_flags)
       return;
 
-    satisfiable_flags_ = new_satisfiable_flags;
-    StateChangedNoLock();
+    state_.satisfiable_flags = new_satisfiable_flags;
+    WaitFlagsStateChangedNoLock();
   }
 
   virtual Type GetType() const OVERRIDE {
     return kTypeUnknown;
   }
 
  private:
   friend class base::RefCountedThreadSafe<MockSimpleDispatcher>;
   virtual ~MockSimpleDispatcher() {}
 
   virtual scoped_refptr<Dispatcher>
       CreateEquivalentDispatcherAndCloseImplNoLock() OVERRIDE {
     scoped_refptr<MockSimpleDispatcher> rv(new MockSimpleDispatcher());
-    rv->satisfied_flags_ = satisfied_flags_;
-    rv->satisfiable_flags_ = satisfiable_flags_;
+    rv->state_ = state_;
     return scoped_refptr<Dispatcher>(rv.get());
   }
 
   // |SimpleDispatcher| implementation:
-  virtual MojoWaitFlags SatisfiedFlagsNoLock() const OVERRIDE {
+  virtual WaitFlagsState GetWaitFlagsStateNoLock() const OVERRIDE {
     lock().AssertAcquired();
-    return satisfied_flags_;
-  }
-
-  virtual MojoWaitFlags SatisfiableFlagsNoLock() const OVERRIDE {
-    lock().AssertAcquired();
-    return satisfiable_flags_;
+    return state_;
   }
 
   // Protected by |lock()|:
-  MojoWaitFlags satisfied_flags_;
-  MojoWaitFlags satisfiable_flags_;
+  WaitFlagsState state_;
 
   DISALLOW_COPY_AND_ASSIGN(MockSimpleDispatcher);
 };
 
 TEST(SimpleDispatcherTest, Basic) {
   test::Stopwatch stopwatch;
 
   scoped_refptr<MockSimpleDispatcher> d(new MockSimpleDispatcher());
   Waiter w;
 
@@ skipping 398 matching lines @@
     EXPECT_TRUE(did_wait[i]);
     EXPECT_EQ(MOJO_RESULT_DEADLINE_EXCEEDED, result[i]);
   }
 }
 
 // TODO(vtl): Stress test?
 
 }  // namespace
 }  // namespace system
 }  // namespace mojo