Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 325143002: Oilpan: Prepare moving inspector script related classes to oilpan. (Closed)

Created:
6 years, 6 months ago by keishi
Modified:
6 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, aandrey+blink_chromium.org, rwlbuis, falken, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, horo+watch_chromium.org, sergeyv+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Oilpan: Prepare moving inspector script related classes to oilpan. This moves the following classes to the heap: JavaScriptCallFrame ScriptArguments ScriptCallStack ScriptProfile BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176021

Patch Set 1 #

Patch Set 2 : #

Total comments: 12

Patch Set 3 : #

Patch Set 4 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -162 lines) Patch
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/PageScriptDebugServer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/PageScriptDebugServer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.cpp View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/v8/ScriptProfiler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptProfiler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 2 3 4 chunks +18 lines, -6 lines 0 comments Download
M Source/core/dom/ExecutionContextClient.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Console.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Console.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/ConsoleBase.h View 3 chunks +16 lines, -16 lines 0 comments Download
M Source/core/frame/ConsoleBase.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/FrameConsole.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/FrameConsole.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/ScriptArguments.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/ScriptArguments.cpp View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.cpp View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/inspector/ScriptProfile.h View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/inspector/TimelineRecordFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
keishi
6 years, 6 months ago (2014-06-11 06:05:21 UTC) #1
haraken
LGTM in terms of oilpan. Let's wait for an approval from pfeldman or yurys. https://codereview.chromium.org/325143002/diff/20001/Source/bindings/v8/ScriptDebugServer.cpp ...
6 years, 6 months ago (2014-06-11 06:27:36 UTC) #2
yurys
lgtm https://codereview.chromium.org/325143002/diff/20001/Source/bindings/v8/ScriptCallStackFactory.h File Source/bindings/v8/ScriptCallStackFactory.h (right): https://codereview.chromium.org/325143002/diff/20001/Source/bindings/v8/ScriptCallStackFactory.h#newcode51 Source/bindings/v8/ScriptCallStackFactory.h:51: PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(v8::Handle<v8::StackTrace>, size_t maxStackSize, v8::Isolate*); Just wondering how ...
6 years, 6 months ago (2014-06-11 11:45:48 UTC) #3
haraken
https://codereview.chromium.org/325143002/diff/20001/Source/bindings/v8/ScriptCallStackFactory.h File Source/bindings/v8/ScriptCallStackFactory.h (right): https://codereview.chromium.org/325143002/diff/20001/Source/bindings/v8/ScriptCallStackFactory.h#newcode51 Source/bindings/v8/ScriptCallStackFactory.h:51: PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(v8::Handle<v8::StackTrace>, size_t maxStackSize, v8::Isolate*); On 2014/06/11 11:45:47, yurys ...
6 years, 6 months ago (2014-06-11 11:50:43 UTC) #4
keishi
https://codereview.chromium.org/325143002/diff/20001/Source/bindings/v8/ScriptDebugServer.cpp File Source/bindings/v8/ScriptDebugServer.cpp (right): https://codereview.chromium.org/325143002/diff/20001/Source/bindings/v8/ScriptDebugServer.cpp#newcode345 Source/bindings/v8/ScriptDebugServer.cpp:345: return PassRefPtrWillBeRawPtr<JavaScriptCallFrame>(); On 2014/06/11 06:27:36, haraken wrote: > > ...
6 years, 6 months ago (2014-06-11 14:40:55 UTC) #5
haraken
LGTM
6 years, 6 months ago (2014-06-11 15:25:20 UTC) #6
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 6 months ago (2014-06-12 03:06:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/325143002/40001
6 years, 6 months ago (2014-06-12 03:06:52 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-12 06:20:29 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 06:39:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/2187)
6 years, 6 months ago (2014-06-12 06:39:44 UTC) #11
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 6 months ago (2014-06-12 11:14:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/325143002/60001
6 years, 6 months ago (2014-06-12 11:16:23 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:24:21 UTC) #14
Message was sent while issue was closed. 
Change committed as 176021

Powered by Google App Engine
This is Rietveld 408576698