Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 325143002: Oilpan: Prepare moving inspector script related classes to oilpan. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | Source/core/inspector/InspectorInstrumentation.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp
index bec67a55aaf5169e35ce4a683fed9150dd4fec60..7cc104ebc55480f64732856fd2ae304dd2918074 100644
--- a/Source/core/inspector/InspectorDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp
@@ -266,12 +266,12 @@ void InspectorDebuggerAgent::addMessageToConsole(MessageSource source, MessageTy
breakProgram(InspectorFrontend::Debugger::Reason::Assert, nullptr);
}
-void InspectorDebuggerAgent::addMessageToConsole(MessageSource source, MessageType type, MessageLevel, const String&, ScriptCallStack*, unsigned long)
+void InspectorDebuggerAgent::addMessageToConsole(MessageSource source, MessageType type, MessageLevel, const String&, PassRefPtrWillBeRawPtr<ScriptCallStack>, unsigned long)
{
addMessageToConsole(source, type);
}
-void InspectorDebuggerAgent::addMessageToConsole(MessageSource source, MessageType type, MessageLevel, const String&, ScriptState*, ScriptArguments*, unsigned long)
+void InspectorDebuggerAgent::addMessageToConsole(MessageSource source, MessageType type, MessageLevel, const String&, ScriptState*, PassRefPtrWillBeRawPtr<ScriptArguments>, unsigned long)
{
addMessageToConsole(source, type);
}
@@ -476,7 +476,7 @@ ScriptDebugListener::SkipPauseRequest InspectorDebuggerAgent::shouldSkipExceptio
{
// FIXME: Fast return: if (!m_cachedSkipStackRegExp && !has_any_anti_breakpoint) return ScriptDebugListener::NoSkip;
- RefPtr<JavaScriptCallFrame> topFrame = scriptDebugServer().topCallFrameNoScopes();
+ RefPtrWillBeRawPtr<JavaScriptCallFrame> topFrame = scriptDebugServer().topCallFrameNoScopes();
if (!topFrame)
return ScriptDebugListener::NoSkip;
@@ -529,7 +529,7 @@ ScriptDebugListener::SkipPauseRequest InspectorDebuggerAgent::shouldSkipStepPaus
if (!m_cachedSkipStackRegExp)
return ScriptDebugListener::NoSkip;
- RefPtr<JavaScriptCallFrame> topFrame = scriptDebugServer().topCallFrameNoScopes();
+ RefPtrWillBeRawPtr<JavaScriptCallFrame> topFrame = scriptDebugServer().topCallFrameNoScopes();
String scriptUrl = scriptURL(topFrame.get());
if (scriptUrl.isEmpty() || m_cachedSkipStackRegExp->match(scriptUrl) == -1)
return ScriptDebugListener::NoSkip;
@@ -901,7 +901,7 @@ void InspectorDebuggerAgent::compileScript(ErrorString* errorString, const Strin
String exceptionDetailsText;
int lineNumberValue = 0;
int columnNumberValue = 0;
- RefPtr<ScriptCallStack> stackTraceValue;
+ RefPtrWillBeRawPtr<ScriptCallStack> stackTraceValue;
scriptDebugServer().compileScript(injectedScript.scriptState(), expression, sourceURL, &scriptIdValue, &exceptionDetailsText, &lineNumberValue, &columnNumberValue, &stackTraceValue);
if (!scriptIdValue && !exceptionDetailsText) {
*errorString = "Script compilation failed";
@@ -938,7 +938,7 @@ void InspectorDebuggerAgent::runScript(ErrorString* errorString, const ScriptId&
String exceptionDetailsText;
int lineNumberValue = 0;
int columnNumberValue = 0;
- RefPtr<ScriptCallStack> stackTraceValue;
+ RefPtrWillBeRawPtr<ScriptCallStack> stackTraceValue;
scriptDebugServer().runScript(injectedScript.scriptState(), scriptId, &value, &wasThrownValue, &exceptionDetailsText, &lineNumberValue, &columnNumberValue, &stackTraceValue);
if (value.isEmpty()) {
*errorString = "Script execution failed";
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | Source/core/inspector/InspectorInstrumentation.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698